Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing @madeRequired decorator for versioning #2731

Closed
marcselman opened this issue Dec 5, 2023 · 2 comments · Fixed by #3292
Closed

Missing @madeRequired decorator for versioning #2731

marcselman opened this issue Dec 5, 2023 · 2 comments · Fixed by #3292
Assignees
@timotheeguerin
Labels
triaged:core
Milestone
[2024] June

Comments

@marcselman
Copy link

I have a datamodel that changed from being optional to being required in a newer version.
There is a nice @madeOptional decorator, but there is no @madeRequired decorator.
There are some workarounds but they do not exactly generate the wanted results.
Is this something that can be easily added?
@timotheeguerin timotheeguerin added this to the [2024] February milestone Dec 11, 2023
@timotheeguerin
Copy link
Member

est: 8

@markcowl markcowl modified the milestones: [2024] March, [2024] April Mar 11, 2024
@markcowl markcowl modified the milestones: [2024] April, [2024] June Apr 6, 2024
@borrrden
Copy link
Contributor

borrrden commented May 1, 2024

I would also like to see this become a reality....not sure what the alternative is.

@borrrden borrrden mentioned this issue May 7, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this May 9, 2024
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
@borrrden @timotheeguerin
Add madeRequired decorator and tests (#3292)
bdb3f24 
Hopefully I got all the places I needed to get and added enough tests.
My methodology was pretty much "Look at what madeOptional does, and do
the opposite"

Closes #2731

---------

Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
triaged:core
Projects
None yet
Milestone
[2024] June
Development

Successfully merging a pull request may close this issue.

Add madeRequired decorator and tests borrrden/typespec
5 participants
@marcselman @timotheeguerin @markcowl @borrrden @allenjzhang