Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add kebab and snake case support to export-name rule #843

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

Tsmith18256
Copy link
Contributor

@Tsmith18256 Tsmith18256 commented Mar 13, 2019

PR checklist

Overview of change:

Right now the export-name rule only works for files that are named in pascal- or camel-case. This PR adds support for files named in kebab- or snake-case.

@msftclas
Copy link

msftclas commented Mar 13, 2019

CLA assistant check
All CLA requirements met.

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Tsmith18256! 🔥

@JoshuaKGoldberg
Copy link

Travis failures are unrelated. Will fix separately.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 5bf89b8 into microsoft:master Mar 13, 2019
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.1.1-beta milestone Apr 15, 2019
@IllusionMH IllusionMH modified the milestones: 6.1.1-beta, 6.2.0-beta May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export-name does not work with kebab/snake case
4 participants