Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Convert no-for-in rule to use walk function #682

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Convert no-for-in rule to use walk function #682

merged 3 commits into from
Dec 18, 2018

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Dec 18, 2018

PR checklist

Overview of change:

  • Updates the template used for generating new rules to use the walk function.
  • Updates the no-for-in rule to use the walk function.

#680 covers all the rules, so this is just the first of hopefully many...bandwidth permitting. 😄

JoshuaKGoldberg
JoshuaKGoldberg suggested changes Dec 18, 2018
View reviewed changes
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to fix up, but otherwise straightforward. Exciting to see these start to come in!

src/noForInRule.ts Outdated Show resolved Hide resolved
build-tasks/templates/rule.template.js Outdated Show resolved Hide resolved
@drexler drexler force-pushed the noForInRule-walk-conversion branch from 00e02af to 8adb529 Compare December 18, 2018 10:12
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 18, 2018
Closed
@JoshuaKGoldberg
Copy link

PR failures are unrelated and only on Node 6: #684

Thanks @drexler!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4db1bdb into microsoft:master Dec 18, 2018
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 18, 2018
Closed
@drexler
Copy link
Contributor Author

drexler commented Dec 18, 2018

Thanks for the review @JoshuaKGoldberg

@drexler drexler deleted the noForInRule-walk-conversion branch December 26, 2018 17:59
@IllusionMH IllusionMH added this to the 6.1.0-beta milestone Feb 19, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
@drexler @apawast
Convert no-for-in rule to use walk function (microsoft#682)
ad19404 
* convert no-for-in rule to use walk function

* update rule generation template to use walk function

* Reverted changes to rule.template.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0-beta
Development

Successfully merging this pull request may close these issues.

Convert all existing rules to use a walk function instead of extending AbstractRule
3 participants
@drexler @JoshuaKGoldberg @IllusionMH