This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add watcher that will run tests and lint #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Oct 30, 2018
Normally I'd say yes, but since they're in the same area and the changes aren't functional, seems fine for now. Would you mind filing issues for followups you'd like to see? I have a few ideas but don't want to trample over yours first 🙂. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continues efforts to replace Grunt with npm scripts #484 and adds watcher that wasn't implemented in scope of #584.
New script
watch:run-testadded that will watch compiled.jsfiles indist,test-dataandtestfolders content and run tests and lint tasks for repo.Custom implementation used instead of
chokidar-clibecause later doesn't wait before command will be finished before starting new one, which might lead to running 2-3 parallel Mocha tests.Possible future improvements:
--skip-initialflag that will skip initial run of tests (when watcher ready)--restart-on-changeflag that will stop currently running tests if watched file is changes (ATM blocked at Feature request: Abort all tasks in Node API mysticatea/npm-run-all#51)Also contains fixes for inconsistent quotes in other JS files. Remove from this PR?