This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Handle relative paths in exceptions for react-no-dangerous-html rule #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Ah shoot. I guess |
kevinwilde
force-pushed
the
react-no-dangerous-html-exception-relative-path
branch
from
2005799 to
8b01053
Compare
kevinwilde
commented
Oct 10, 2018
| } else { | ||
| filename = 'file.ts'; | ||
| filename = Utils.absolutePath('file.ts'); |
There was a problem hiding this comment.
The tests previously just used 'file.ts(x)' as a mock filename. Since reactNoDangerousHtmlRule now compares Utils.absolutePath(exception.file) to this.getSourceFile().fileName (which also returns an absolute path when running tslint on an actual project) we need the tests to provide an absolute path for the filename, as well.
Unfortunately, this means I had to change a lot of test files, so this PR has a lot of line changes.
kevinwilde
force-pushed
the
react-no-dangerous-html-exception-relative-path
branch
from
8b01053 to
d0ad9d7
Compare
JoshuaKGoldberg
approved these changes
Oct 14, 2018
There was a problem hiding this comment.
What a large PR for such a small source change...! Thanks @kevinwilde! 🙌
This was referenced Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537