Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix #437: Add undefined check before using toLowerCase #507

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix #437: Add undefined check before using toLowerCase #507

merged 1 commit into from
Oct 2, 2018

Conversation

joostme
Copy link

@joostme joostme commented Oct 2, 2018

Add undefined check before using .toLowerCase() on getStringLiteral(typeAttribute) to make the rule pass when the expression for the type of an input is undefined.

Fixes #437

@msftclas
Copy link

msftclas commented Oct 2, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d3fb2f3 into microsoft:master Oct 2, 2018
@JoshuaKGoldberg
Copy link

Awesome, thanks @joostme!

@joostme joostme deleted the pr/react-a11y-image-button-has-alt branch October 22, 2018 06:22
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0-beta0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@joostme @msftclas @JoshuaKGoldberg