This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix several edge cases in the no-octal-literal rule. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iclanton
commented
Jan 31, 2018
iclanton
commented
- The no-octal-literal rule ignored template strings
- The no-octal-literal rule didn't match strings containing newline or tab characters
- The no-octal-literal rule incorrectly matched escaped backslashes preceding numbers (i.e. - "\\1" matched when it shouldn't have)
…ded by an escaped backslash would fail the rule.
…ngs or newlines inside strings.
HamletDRC
pushed a commit
that referenced
this pull request
Apr 16, 2018
…receeded by an escaped backslash would fail the rule. Fixing an issue where the no-octal-rule wouldn't handle template strings or newlines inside strings. Fixing test numbering. Fixing duplicate variable declaration.
|
@iclanton I pushed this... but the whole Octal rule is a little funky. It only looks inside strings for octal literals. The eslint rule looks into constants as well, which we don't do: https://eslint.org/docs/rules/no-octal |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.