#337 Performance: Replace noHttpStringRule regex with indexOf

closes #337 closes #336
microsoft · Feb 2, 2017 · be8c298 · be8c298
1 parent a05a003
commit be8c298
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/noHttpStringRule.ts b/src/noHttpStringRule.ts
@@ -39,7 +39,8 @@ export class Rule extends Lint.Rules.AbstractRule {
 class NoHttpStringWalker extends ErrorTolerantWalker {
     protected visitStringLiteral(node: ts.StringLiteral): void {
         const stringText : string = (<ts.LiteralExpression>node).text;
-        if (/.*http:.*/.test(stringText)) {
+        // tslint:disable no-http-string
+        if (stringText.indexOf('http:') !== -1) {
             if (!this.isSuppressed(stringText)) {
                 const failureString = Rule.FAILURE_STRING + '\'' + stringText + '\'';
                 const failure = this.createFailure(node.getStart(), node.getWidth(), failureString);