Add more standard tag definitions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the standard definitions
…tiple, since in practice most tags are single-usage
iclanton
reviewed
Aug 23, 2018
tsdoc/src/details/StandardTags.ts
Outdated
| * Example implementations: API Extractor | ||
| */ | ||
| public static readonly internalRemarks: TSDocTagDefinition = StandardTags._defineTag({ | ||
| tagName: '@internalRemarks', |
There was a problem hiding this comment.
internal [](start = 15, length = 8)
@privateRemarks? #Resolved
iclanton
reviewed
Aug 23, 2018
tsdoc/src/details/StandardTags.ts
Outdated
| * | ||
| * Example implementations: API Extractor | ||
| */ | ||
| public static readonly preapproved: TSDocTagDefinition = StandardTags._defineTag({ |
There was a problem hiding this comment.
preapproved [](start = 25, length = 11)
This is too obscure to be in the standard. #Resolved
iclanton
reviewed
Aug 23, 2018
tsdoc/src/details/StandardTags.ts
Outdated
| StandardTags.param, | ||
| StandardTags.readonly, | ||
| StandardTags.remarks, | ||
| StandardTags.returns |
There was a problem hiding this comment.
There are a few missing here. #Resolved
|
This PR was published as @microsoft/tsdoc version 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
CoreTagsAPI toStandardTagsand introduce a distinction between "core", "extended", and "discretionary" standard tags.