-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing minimum tests #932
Conversation
Good catch! Looks like we'll also need to bump our pandas min version as a result. @isaaccorley any updates on the pyvista PR? |
Edit: Think I'll just go ahead and push it here since the goal is to fix the failing tests. |
Really kicked the hornet's nest with this one. Will need some time to find a stable configuration. Current constraint: open3d 0.13.0 depends on jupyter-packaging~=0.10 and jupyter-packaging 0.10+ depends on setuptools>=46.4.0. Seems open3d pinned jupyter-packaging~=0.10 to support Python 3.6. |
Got stung a few times but things look stable now. Summary of changes and reasons: open3d (
|
Let's silence that warning in |
Seems like this was already added in Edit: Ah nvm this was coming from |
I stay up late at night regretting ever adding open3d as a dependency. |
Do you think we should push forward and merge this PR and then revert it if we get pyvista working, or is pyvista close? We could skip pyvista tests on macOS/Windows if those are too hard to test. |
If we can skip windows and mac tests then we could get pyvista in. It's just a matter of installing xvfb via apt in the github action and then running pyvista.start_xvfb() prior to the plot test. |
This PR fixes the cause for the minimum tests failing in #854 (and presumably any PR created after Dec 1st).
scikit-learn
has officially begun deprecatingsklearn
to prevent malicious actors from using it. So any dependency that attempts to installsklearn
would install the newsklearn
package which throws an exception at certain intervals - Refer https://pypi.org/project/sklearn/ for more details.open3d=0.11.2
was our problem package. The open3d team had switched fromsklearn
toscikit-learn
in version0.13.0
. This PR bumps the minimum version to the same.It seems there was a PR prepped to replace
open3d
withpyvista
- #663. If this lands for the0.4.0
release, this PR can be ignored.