Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing minimum tests #932

Closed
wants to merge 17 commits into from
Closed

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Dec 5, 2022

This PR fixes the cause for the minimum tests failing in #854 (and presumably any PR created after Dec 1st).

scikit-learn has officially begun deprecating sklearn to prevent malicious actors from using it. So any dependency that attempts to install sklearn would install the new sklearn package which throws an exception at certain intervals - Refer https://pypi.org/project/sklearn/ for more details.

open3d=0.11.2 was our problem package. The open3d team had switched from sklearn to scikit-learn in version 0.13.0. This PR bumps the minimum version to the same.

It seems there was a PR prepped to replace open3d with pyvista - #663. If this lands for the 0.4.0 release, this PR can be ignored.

@ashnair1 ashnair1 changed the title Bump min version of open3d Bump min version of open3d to fix min tests Dec 5, 2022
@adamjstewart adamjstewart added this to the 0.3.2 milestone Dec 5, 2022
@adamjstewart
Copy link
Collaborator

Good catch! Looks like we'll also need to bump our pandas min version as a result. @isaaccorley any updates on the pyvista PR?

@adamjstewart adamjstewart added the dependencies Packaging and dependencies label Dec 5, 2022
setup.cfg Outdated Show resolved Hide resolved
@ashnair1
Copy link
Collaborator Author

ashnair1 commented Dec 6, 2022

Good catch! Looks like we'll also need to bump our pandas min version as a result. @isaaccorley any updates on the pyvista PR?

Indeed. Do you recommend that be done in a separate PR? Or shall I just include it here and change the issue title to "Fix failing min tests"?

Edit: Think I'll just go ahead and push it here since the goal is to fix the failing tests.

@ashnair1 ashnair1 changed the title Bump min version of open3d to fix min tests Fix failing minimum tests Dec 6, 2022
@ashnair1 ashnair1 marked this pull request as draft December 6, 2022 06:39
@ashnair1
Copy link
Collaborator Author

ashnair1 commented Dec 6, 2022

Really kicked the hornet's nest with this one. Will need some time to find a stable configuration.

Current constraint:

open3d 0.13.0 depends on jupyter-packaging~=0.10 and jupyter-packaging 0.10+ depends on setuptools>=46.4.0.

Seems open3d pinned jupyter-packaging~=0.10 to support Python 3.6.

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Dec 7, 2022

Got stung a few times but things look stable now.

Summary of changes and reasons:

open3d (0.13.0) required the following packages to be updated

  • setuptools (indirectly)
  • pandas
  • numpy
  • pillow
  • ipywidgets

rasterio was updated to avoid a deprecation warning caused by importing Iterable from collections.
nbconvert was pinned to reduce the resolve time. Without this, time required for running the minimum test jumped to 10 min.

@ashnair1 ashnair1 marked this pull request as ready for review December 7, 2022 09:34
@adamjstewart
Copy link
Collaborator

rasterio was updated to avoid a deprecation warning caused by importing Iterable from collections.

Let's silence that warning in pyproject.toml instead.

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Dec 7, 2022

rasterio was updated to avoid a deprecation warning caused by importing Iterable from collections.

Let's silence that warning in pyproject.toml instead.

Seems like this was already added in pyproject.toml line 80

Edit: Ah nvm this was coming from rasterio.transform

@isaaccorley
Copy link
Collaborator

I stay up late at night regretting ever adding open3d as a dependency.

@adamjstewart
Copy link
Collaborator

Do you think we should push forward and merge this PR and then revert it if we get pyvista working, or is pyvista close? We could skip pyvista tests on macOS/Windows if those are too hard to test.

@isaaccorley
Copy link
Collaborator

If we can skip windows and mac tests then we could get pyvista in. It's just a matter of installing xvfb via apt in the github action and then running pyvista.start_xvfb() prior to the plot test.

@adamjstewart adamjstewart modified the milestones: 0.3.2, 0.4.0 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Packaging and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants