Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDTReeS: remove support for plotting lidar point cloud #2428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamjstewart
Copy link
Collaborator

I don't think this feature (IDTReeS.plot_las) is widely used and it requires multiple dependencies (pyvista, pyvista/setup-headless-display-action) just to test. Visualization has always been orthogonal to TorchGeo's goals. We would like the bare minimum plotting capable in matplotlib. Users can always use PyVista themselves outside of TorchGeo.

@adamjstewart adamjstewart added the backwards-incompatible Changes that are not backwards compatible label Nov 26, 2024
@adamjstewart adamjstewart added this to the 0.7.0 milestone Nov 26, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation datasets Geospatial or benchmark datasets testing Continuous integration testing dependencies Packaging and dependencies labels Nov 26, 2024
@adamjstewart
Copy link
Collaborator Author

I wonder how people would feel about also removing our dependency on laspy, IDTReeS is the only dataset that uses it right now and none of our trainers know what to do with point clouds. Are we planning on adding more lidar datasets in the future?

@adamjstewart
Copy link
Collaborator Author

We can also plot the 3D point cloud in matplotlib if this is a useful feature, PyVista is just overkill for our needs.

@calebrob6
Copy link
Member

calebrob6 commented Jan 6, 2025

I agree (and would like to remove laspy) -- I'm wondering if we can make this a tutorial or put this snippet somewhere though so people can copy if they want?

@adamjstewart
Copy link
Collaborator Author

and would like to remove laspy

I'm actually now hesitating about this. I had one audience member at AGU who was particularly interested in lidar support. It's similar to SAR support, where a lot of domain expertise is required to do things correctly and we won't have that until someone contributes it, but I would love to expand our lidar support if we can.

I'm wondering if we can make this a tutorial or put this snippet somewhere though so people can copy if they want?

I would suggest here: https://tutorial.pyvista.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Changes that are not backwards compatible datasets Geospatial or benchmark datasets dependencies Packaging and dependencies documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants