-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.9 support #1966
Merged
Merged
Drop Python 3.9 support #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
testing
Continuous integration testing
dependencies
Packaging and dependencies
labels
Mar 27, 2024
github-actions
bot
added
datasets
Geospatial or benchmark datasets
models
Models and pretrained weights
samplers
Samplers for indexing datasets
trainers
PyTorch Lightning trainers
transforms
Data augmentation transforms
datamodules
PyTorch Lightning datamodules
scripts
Training and evaluation scripts
labels
Mar 27, 2024
This is an if expression, not an elif expression. And Python match statements do not support fall-through. |
isaaccorley
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked each change and looks good
calebrob6
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
datamodules
PyTorch Lightning datamodules
datasets
Geospatial or benchmark datasets
dependencies
Packaging and dependencies
documentation
Improvements or additions to documentation
models
Models and pretrained weights
samplers
Samplers for indexing datasets
scripts
Training and evaluation scripts
testing
Continuous integration testing
trainers
PyTorch Lightning trainers
transforms
Data augmentation transforms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's that time of year again!
We've been following NEP 29 for a while now to decide when to drop support for older Python versions. However, NEP 29 is now superseded by SPEC 0. Although NEP 29 adopted a 3.5 year support strategy, SPEC 0 now adopts a shorter 3 year support strategy. Since a new Python minor release happens once a year, this means support for the 3 most recent Python minor versions. However, PyTorch is slow to adopt the latest Python version after it gets released, so I propose waiting until it is fully supported before dropping the oldest version.
The biggest change in Python 3.10 is support for
X | Y
as a replacement fortyping.Union[X, Y]
andX | None
as a replacement forOptional[X]
. This means thattyping
no longer needs to be imported by most files! It's also an excuse to bump the minimum supported version for many of our dependencies.