Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AgriFieldNet India Challenge dataset #1459

Merged
merged 52 commits into from
Feb 12, 2024

Conversation

yichiac
Copy link
Contributor

@yichiac yichiac commented Jul 3, 2023

This PR adds the AgriFieldNet India Challenge dataset. The dataset contains pre-chipped Sentinel-2 imagery and labels for crop type in India.

Challenge
Dataset overview

The downloader for Source Cooperative needs to migrate from Radiant MLHub to Source Cooperative #1830. Due to the migration process not yet being finalized, the PR currently does not implement the automatic download feature.

A significant portion of the datasets available through this service are provided as compressed files, which facilitates the use of checksums for integrity verification. However, this dataset is distributed via directories and individual files. This structure presents a challenge for implementing standard checksum verification procedures.

Given this scenario, we have yet to establish a robust method for checksumming these non-compressed files and directories. Consequently, this PR temporarily suspends the execution of check_integrity and related checksum functions until a viable solution is determined.

agrifieldnet_test
agrifieldnet_test2

@github-actions github-actions bot added datamodules PyTorch Lightning datamodules datasets Geospatial or benchmark datasets testing Continuous integration testing labels Jul 3, 2023
@adamjstewart adamjstewart added this to the 0.5.0 milestone Jul 3, 2023
@adamjstewart
Copy link
Collaborator

Not sure if you can see it but https://app.codecov.io/gh/microsoft/torchgeo/pull/1459 tells you which lines are missing coverage. You can also check this from the command line: https://torchgeo.readthedocs.io/en/stable/user/contributing.html#tests

Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you upload an example plot to make sure everything looks correct?

torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datamodules/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added trainers PyTorch Lightning trainers scripts Training and evaluation scripts labels Jul 10, 2023
@calebrob6
Copy link
Member

@yichiac do you need help with this?

@yichiac yichiac closed this Jul 19, 2023
@yichiac yichiac reopened this Jul 19, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed trainers PyTorch Lightning trainers labels Feb 2, 2024
@yichiac yichiac marked this pull request as ready for review February 2, 2024 06:52
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove everything related to downloading (including comments) until we actually support it in the future.

torchgeo/datasets/__init__.py Outdated Show resolved Hide resolved
torchgeo/datamodules/__init__.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the datamodules PyTorch Lightning datamodules label Feb 6, 2024
@adamjstewart adamjstewart added this to the 0.6.0 milestone Feb 11, 2024
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just a couple remaining comments

torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
torchgeo/datasets/agrifieldnet.py Outdated Show resolved Hide resolved
yichiac and others added 3 commits February 11, 2024 19:25
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
@adamjstewart
Copy link
Collaborator

Confirmed 100% test coverage locally.

@adamjstewart adamjstewart merged commit 8af188c into microsoft:main Feb 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants