Fixing issues with deployment item from VS IDE #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…item attribute over to the desktop Fx extension. This fixes two issues: 1. It ensures that the Fx extension assembly gets deployed as well so it can be used at runtime. 2. Removes confusion of DeploymentItem support in UWP and Core as its a no-op today without any warnings/notification.
|
@AbhitejJohn, |
codito
reviewed
Mar 6, 2017
| /// [DeploymentItem("bin\Debug")] | ||
| /// </example> | ||
| [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = true)] | ||
| public sealed class DeploymentItemAttribute : Attribute |
There was a problem hiding this comment.
Should we not support it for .NETCore?
There was a problem hiding this comment.
Added the attribute in .Net Core as well. This would however not be visible in UWP since it does not even make sense there.
… breaks. Added this with an obsolete tag though for lack of any other "warning" infrastructure. The message for customers using DeploymentItem in .Net Core projects would look like below: "warning CS0618: 'DeploymentItemAttribute' is obsolete: 'DeploymentItemAttribute is currently not supported in .Net Core. This is just a placehodler for support in the future.'"
…r other tools. Adding it in the remarks section however - Not good enough to inform the user though. But when we go OSS the issue that DI is not working in .Net Core should be visible.
|
Validated all DeploymentItem related scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the DeploymentItem attribute over to the desktop Fx extension. This fixes two issues: