Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for configuring starting directory in SUI when defaults sets it to null #9862

Merged
1 commit merged into from
Apr 21, 2021
Merged

Fix for configuring starting directory in SUI when defaults sets it to null #9862

1 commit merged into from
Apr 21, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Apr 16, 2021 •
edited by DHowett
Loading

Summary of the Pull Request

Remove an unnecessary check in Profiles.cpp that was preventing us from enabling the text box and browse button when the user unchecks 'use parent process directory'

PR Checklist

Validation Steps Performed

Played around with it and it works.

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Apr 16, 2021
carlos-zamora
carlos-zamora approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DHowett
Copy link
Member

DHowett commented Apr 19, 2021

I'd love to understand why these checks were added -- @zadjii-msft any idea? I think your Background Image code was the first to have it

@DHowett
Copy link
Member

DHowett commented Apr 19, 2021

Oh, @carlos-zamora added it in #8919...

image

@carlos-zamora
Copy link
Member

Oh, @carlos-zamora added it in #8919...

image

@PankajBhojwani Just to be safe, mind testing this with the inheritance system? Like, check how it works when a fragment-extension is setting the background image and starting directory to null.

carlos-zamora
carlos-zamora requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, yeah, always calling the setter can be a problem when we start thinking about inheritance. I think we may still need to keep into account whether the user explicitly set the value or not still.

Best way to test this out is playing with base layer and fragment extensions and making sure the UI is correct when the value is inherited.

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 19, 2021
carlos-zamora
carlos-zamora approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PankajBhojwani verified that this now works as intended. Thank you!

Tested scenarios...

  • fragment extension set starting directory to null
  • fragment extension set starting directory to an actual value
  • override the inherited values from above

The reset arrow appears when appropriate, and the checkbox works as intended.

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 21, 2021
@ghost
Copy link

ghost commented Apr 21, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ad34291 into main Apr 21, 2021
@ghost ghost deleted the dev/pabhoj/starting_dir_fix branch April 21, 2021 10:53
@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Apr 21, 2021
@DHowett DHowett removed the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label May 14, 2021
DHowett pushed a commit that referenced this pull request May 14, 2021
@PankajBhojwani @DHowett
Fix for configuring starting directory in SUI when defaults sets it t…
c38696d 
…o null (#9862)

## Summary of the Pull Request
Remove an unnecessary check in `Profiles.cpp` that was preventing us from enabling the text box and browse button when the user unchecks 'use parent process directory'

## PR Checklist
* [x] Closes #9847
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Played around with it and it works.

(cherry picked from commit ad34291)
DHowett pushed a commit that referenced this pull request May 14, 2021
@PankajBhojwani @DHowett
Fix for configuring starting directory in SUI when defaults sets it t…
fba9493 
…o null (#9862)

## Summary of the Pull Request
Remove an unnecessary check in `Profiles.cpp` that was preventing us from enabling the text box and browse button when the user unchecks 'use parent process directory'

## PR Checklist
* [x] Closes #9847
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Played around with it and it works.

(cherry picked from commit ad34291)
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 25, 2021
Closed
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label May 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot configure starting directory in GUI when its default value is set to null
4 participants
@PankajBhojwani @DHowett @carlos-zamora @zadjii-msft