Add a success dialog to window renaming #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-User Interface
ghost
added
the
Area-Settings
miniksa
reviewed
Apr 14, 2021
miniksa
approved these changes
Apr 14, 2021
carlos-zamora
requested changes
Apr 21, 2021
| @@ -1,17 +1,17 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
nit: undo changes to this file
ghost
added
the
Needs-Author-Feedback
|
moved from body |
DHowett
added
the
zPreview-Service-Queued-1.13
DHowett
approved these changes
Apr 22, 2021
|
@carlos-zamora I addressed your nits |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
Apr 22, 2021
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
May 14, 2021
I added a `RenameSucceededText` property to the `TerminalPage` which returns the
formatted message `Successfully renamed window to "{WindowNameForDisplay()}"`
This _doesn't_ pop the dialog when you `wt -w foo` for the first time. Only
_subsequent_ renames.
## References
* Added in #9662
* Closes #9804
(cherry picked from commit aa54de1)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
DHowett
removed
the
zPreview-Service-Queued-1.13
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
RenameSucceededTextproperty to theTerminalPagewhich returns theformatted message
Successfully renamed window to "{WindowNameForDisplay()}"This doesn't pop the dialog when you
wt -w foofor the first time. Onlysubsequent renames.
References