-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a success dialog to window renaming #9808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this. I just don't like the content of the confirmation toast; feels redundant, but idk how to fix it. Once that gets figured out, I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things. If possible, update the gif in the OP too please.
Also, are we gonna service this?
@@ -1,17 +1,17 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: undo changes to this file
@carlos-zamora I addressed your nits |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
I added a `RenameSucceededText` property to the `TerminalPage` which returns the formatted message `Successfully renamed window to "{WindowNameForDisplay()}"` This _doesn't_ pop the dialog when you `wt -w foo` for the first time. Only _subsequent_ renames. ## References * Added in #9662 * Closes #9804 (cherry picked from commit aa54de1)
🎉 Handy links: |
🎉 Handy links: |
I added a
RenameSucceededText
property to theTerminalPage
which returns theformatted message
Successfully renamed window to "{WindowNameForDisplay()}"
This doesn't pop the dialog when you
wt -w foo
for the first time. Onlysubsequent renames.
References