-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the win
key in keybindings
#9783
Conversation
For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows.
Misspellings found, please review:
To accept these changes, run the following commands from this repository on this branch
✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.
If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 🗜️ If you see a bunch of garbage and it relates to a binary-ish string, please add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
it actually works??? this is great |
I'll let you/Michael figure out the regex thing. But don't forget to update the docs plz. We probably want some kind of warning in the docs too. |
TODO:
|
@zadjii-msft - will it affect #9163? |
Oh, this, might. I'll take a look. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking req changes until the regex is sussed out.
…negative look behind at all
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
## Summary of the Pull Request Does what it says on the can. People can now use `win` in a keybinding to indicate that the chord needs <kbd>win</kbd>. ## References * Done for microsoft#653 * See also microsoft#8888 ## PR Checklist * [x] Closes microsoft#3184 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows. * `win+b`: Focus the tray? * `win+t`: Focus the taskbar * `win+p`: Project... * `win+c`: The powertoys color picker * `win+v`: cloud clipboard So the list of valid combos is vanishingly small. It's all about that <kbd>win+~</kbd> ## Validation Steps Performed Bound ```json { "keys": [ "win+`" ], "command": "commandPalette" }, ``` and yea, it works as expected
🎉 Handy links: |
Summary of the Pull Request
Does what it says on the can. People can now use
win
in a keybinding toindicate that the chord needs win.
References
PR Checklist
win
in key bindings? #3184Detailed Description of the Pull Request / Additional comments
For the record, I hate this. But it's great for quake mode, so meh. There's
shockingly more win keys claimed then you think - many more than the shortcut
guide even shows.
win+b
: Focus the tray?win+t
: Focus the taskbarwin+p
: Project...win+c
: The powertoys color pickerwin+v
: cloud clipboardSo the list of valid combos is vanishingly small. It's all about that win+~
Validation Steps Performed
Bound
and yea, it works as expected