-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give our NavigationView's acrylic a fallback color #9752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be a different color than the background, so it will look less weird when it's unfocused. It also fixes the bug where the navigation menu is transparent when acrylic is disabled systemwide. Fixes #9337
ghost
added
Area-SettingsUI
Anything specific to the SUI
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Priority-3
A description (P3)
Product-Terminal
The new Windows Terminal.
labels
Apr 8, 2021
DHowett
added
the
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
label
Apr 8, 2021
zadjii-msft
approved these changes
Apr 8, 2021
carlos-zamora
approved these changes
Apr 8, 2021
zadjii-msft
added
the
AutoMerge
Marked for automatic merge by the bot when requirements are met
label
Apr 9, 2021
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/duhowett/we're_routed_fall_back
branch
April 9, 2021 10:43
DHowett
removed
the
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
label
Apr 13, 2021
🎉 Handy links: |
ghost
mentioned this pull request
Apr 14, 2021
🎉 Handy links: |
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-SettingsUI
Anything specific to the SUI
AutoMerge
Marked for automatic merge by the bot when requirements are met
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Needs-Second
It's a PR that needs another sign-off
Priority-3
A description (P3)
Product-Terminal
The new Windows Terminal.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be a different color than the background, so it will look less
weird when it's unfocused. It also fixes the bug where the navigation
menu is transparent when acrylic is disabled systemwide.
Fixes #9337