Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update {fmt} to 7.1.3 #9580

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Update {fmt} to 7.1.3 #9580

merged 1 commit into from
Mar 22, 2021

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 22, 2021

{fmt} 7.1.3 includes a number of changes, which I will summarize here:

  • Switched to Dragonbox for float formatting (quoted, "20-30x faster"
    than ostringstream)
  • Significantly improves FMT_COMPILE (compile-time format string)

{fmt} 7.1.3 includes a number of changes, which I will summarize here:

* Switched to Dragonbox for float formatting (quoted, "20-30x faster"
  than ostringstream)
* Significantly improves `FMT_COMPILE` (compile-time format string)
@DHowett
Copy link
Member Author

DHowett commented Mar 22, 2021

This provides an alternate solution to #9552 -- using FMT_COMPILE gets the binary to 75k (which is so close to 73k that I hardly care).

Expanded FMT_COMPILE support will also allow us to switch to it in conhost and save about 40kb (!) inside windows.

@DHowett
Copy link
Member Author

DHowett commented Mar 22, 2021

Switching three things inside OpenConsole to FMT_COMPILE shaves 118kb off the Release binary. Windows inbox savings will be a little less because of different optimization flags and PGO and stuff. 😄

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@DHowett DHowett merged commit 544bd44 into main Mar 22, 2021
@DHowett DHowett deleted the dev/duhowett/fmt-7.1.3 branch March 22, 2021 18:07
DHowett added a commit that referenced this pull request Apr 13, 2021
{fmt} 7.1.3 includes a number of changes, which I will summarize here:

* Switched to Dragonbox for float formatting (quoted, "20-30x faster"
  than ostringstream)
* Significantly improves `FMT_COMPILE` (compile-time format string)

(cherry picked from commit 544bd44)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants