Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the erroneous TargetRuntime causing a warning in VS #8895

Merged
2 commits merged into from
Jan 26, 2021
Merged

Fix the erroneous TargetRuntime causing a warning in VS #8895

2 commits merged into from
Jan 26, 2021

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Jan 26, 2021 •
edited by DHowett
Loading

Summary of the Pull Request

Apparently, we don't need this TargetRuntime. That's what was causing VS to think that we were a C# project, and give us that warning. This is the solution we got from the owner of the .wapproj plugin.

References

PR Checklist

Build and ran it fine. Changed TermControl, built and ran it fine. Now let's hope CI likes it.

@ghost ghost added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products. labels Jan 26, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jan 26, 2021
@ghost
Copy link

ghost commented Jan 26, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 2 hours 26 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Jan 26, 2021

@msftbot merge this in 1 minute

@ghost
Copy link

ghost commented Jan 26, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 26 Jan 2021 19:13:16 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 3f1262e into main Jan 26, 2021
@ghost ghost deleted the dev/migrie/b/dustin-why-would-you-do-this branch January 26, 2021 19:14
@skyline75489
Copy link
Collaborator

This is actually the first solution I found immediately after I filed the issue. But i was like “come on this is just ridiculous. there’s no way this is the right fix”. 😅

mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
@zadjii-msft @mpela81
Fix the erroneous TargetRuntime causing a warning in VS (microsoft#8895)
a3be23c 
## Summary of the Pull Request

Apparently, we don't need this `TargetRuntime`. That's what was causing VS to think that we were a C# project, and give us that warning. This is the solution we got from the owner of the `.wapproj` plugin.

## References
* Introduced in c33883d, in PR microsoft#8062

## PR Checklist
* [x] Closes microsoft#8301
* [x] I work here


Build and ran it fine. Changed TermControl, built and ran it fine. Now let's hope CI likes it.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSBuild issues warning on CascadiaPackage in VS 16.8
4 participants
@zadjii-msft @DHowett @skyline75489 @carlos-zamora