-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startupActions to SUI #8812
base: main
Are you sure you want to change the base?
Conversation
@carlos-zamora, @zadjii-msft - marked it as draft because I didn't implement parsed command TextBlock. If it makes sense for 1.6 preview we can probably add this commit and to introduce parsing afterwards. WDYT? I addition I was not sure if we want to limit the length or to add some scrolling. BTW the only reason I didn't introduce parsing is because the parsing logic belongs to the Terminal App which is of course not a dependency of the Editor. |
Alright, had a discussion offline with the team. Since it's a fairly advanced feature, we'll definitely want some validation/parsing on that TextBox. So we'll push this Settings UI change out of the v1.6 release, but keep the feature itself in (but you have to access it via the JSON). As for how to implement the parsing, @zadjii-msft has a branch pulling out the commandline arg parsing into its own lib. He'll hop on here soon for more details on that. I think he said he'd make a PR to check that in?
The style you used makes the text wrap if the text doesn't fit. Let's keep that for now for consistency with other text settings. This is a common problem we have among all of those settings (see background image and icon path), so we're hoping to come up for a more elegant solution at some point. |
Yea so, I have a branch over in I think the commits that are relevant are: ca6a5fb I think we should be able to move the commandline arg parser into it's own lib. Then, we could have both TerminalAppLib and TerminalSettingsEditor reference that lib. That would let the TerminalSettingsEditor create an Theoretically in the future, we could make it it's own DLL too ( So I'll get to working on polishing that. |
@zadjii-msft, @carlos-zamora - Will SUI be released (as stable) in 1.6 or only in 1.7? Because I think that we need to have startupActions by the time SUI released. |
It certainly will not be. We're trying to get back on the monthly release train (after taking a long time with 1.6). That does however mean that 1.7 is extra short. We're still missing a bunch of things before we want to call the SUI "stable", this included. |
PR Checklist
startupActions
to Settings UI #8802Detailed Description of the Pull Request / Additional comments
I wasn't able to add parsed value yet as the parsing logic is in TerminalApp
and thus not accessible from Editor.