Maintain current Pivot selection when saving on the Profiles page #8803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work as I'd hope though. If you manually type in `desktopWallpaper`, then the text box is hidden permanently. This is because the StringIsNotDesktopConverter imediately can tell that the string is desktopWallpaper, and hides the text box, but it _doesn't_ update the checkbox. We're going to have to get creative.
…65-sui-color-scheme-page
…-color-scheme-page # Conflicts: # src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
…65-sui-color-scheme-page
zadjii-msft
added
Issue-Bug
carlos-zamora
approved these changes
Jan 15, 2021
zadjii-msft
changed the base branch from
dev/migrie/b/8765-sui-color-scheme-page
to
main
…e/b/8769a-profiles-pivot
DHowett
approved these changes
Jan 19, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
pushed a commit
that referenced
this pull request
Jan 21, 2021
This reverts commit a7d7362 introduced by #8803. Reverting this commit fixes #8836 at the expense of the profile page remembering the last Pivot selection. The ## References #6800 - Settings UI Epic #8803 maintained a `ProfilePageNavigationState` in `MainPage` to remember the pivot position. However, the two-way binding on the TextBoxes now seem to happen too late (after the navigation occurs), resulting in the text being applied to the wrong profile. In other words, the sequence of events probably looks something like this: 1. user types text (_state.profile = old profile) 2. user moves to new profile 3. navigation completes (_state.profile = new profile) 4. textbox two-way binding fires, setting _state.profile.WHATEVER = value ## Validation Steps Performed Performed repro sets from #8836. Bug no longer occurs. Reopens #8769 Closes #8836
zadjii-msft
added a commit
that referenced
this pull request
Jan 21, 2021
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
…crosoft#8803) This PR Makes sure that after you save the settings, we stay on the same part of the profiles pivot. We do this by having a singleton `ProfilesNavigationState`, a bit like the color scheme one in microsoft#8799. Hence why this PR is targeting the other. ## PR Checklist * [x] I work here * [x] Tested manually * [x] Fixes the first point in microsoft#8769
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
…oft#8838) This reverts commit a7d7362 introduced by microsoft#8803. Reverting this commit fixes microsoft#8836 at the expense of the profile page remembering the last Pivot selection. The ## References microsoft#6800 - Settings UI Epic microsoft#8803 maintained a `ProfilePageNavigationState` in `MainPage` to remember the pivot position. However, the two-way binding on the TextBoxes now seem to happen too late (after the navigation occurs), resulting in the text being applied to the wrong profile. In other words, the sequence of events probably looks something like this: 1. user types text (_state.profile = old profile) 2. user moves to new profile 3. navigation completes (_state.profile = new profile) 4. textbox two-way binding fires, setting _state.profile.WHATEVER = value ## Validation Steps Performed Performed repro sets from microsoft#8836. Bug no longer occurs. Reopens microsoft#8769 Closes microsoft#8836
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Makes sure that after you save the settings, we stay on the same part of the profiles pivot. We do this by having a singleton
ProfilesNavigationState, a bit like the color scheme one in #8799. Hence why this PR is targeting the other.PR Checklist