Use memory pool for PolyTextOut items in GDI Renderer #8619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… just going to use it again and again.
miniksa
added
Product-Conhost
|
Before: After: The allocation count is pretty much gone for |
6 tasks
zadjii-msft
approved these changes
Jan 4, 2021
ghost
requested review from
carlos-zamora,
DHowett,
leonMSFT and
PankajBhojwani
DHowett
approved these changes
Jan 5, 2021
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
Converts the poly text out string and width buffers to use a memory pool since we free/alloc those every frame and are just going to reuse them over and over. ## PR Checklist * [x] Supports microsoft#3075 * [x] I work here. * [x] Profiled memory before/after. Tested manually with `big.txt`. ## Detailed Description of the Pull Request / Additional comments - Sets up a PMR memory pool for the GDI Engine. It tends to alloc and free a bunch of little buffers during painting frames. The pool will likely hold onto that memory frame over frame, but we'd just be using it again and again and again anyway. So this way we avoid all the system memory allocator locks and syscalls. ## Validation Steps Performed - Ran `big.txt` about 10x in the window. Checked WPR/WPA profile output before/after.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the poly text out string and width buffers to use a memory pool since we free/alloc those every frame and are just going to reuse them over and over.
PR Checklist
big.txt.Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
big.txtabout 10x in the window. Checked WPR/WPA profile output before/after.