Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a profile to specify an "unfocused" appearance #8392

Merged
103 commits merged into from
Apr 8, 2021
Merged

Add support for a profile to specify an "unfocused" appearance #8392

103 commits merged into from
Apr 8, 2021

Commits on Nov 20, 2020

  1. add object on Core side

    @PankajBhojwani
    PankajBhojwani committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c6432b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. object in settings model side

    @PankajBhojwani
    PankajBhojwani committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    f806011 View commit details
    Browse the repository at this point in the history

  2. applib side object

    @PankajBhojwani
    PankajBhojwani committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    5aa1e66 View commit details
    Browse the repository at this point in the history

  3. barebones prototype

    @PankajBhojwani
    PankajBhojwani committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    c423e11 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. renaming

    @PankajBhojwani
    PankajBhojwani committed Nov 30, 2020
    1 Configuration menu
    Copy the full SHA
    8f8e6e7 View commit details
    Browse the repository at this point in the history

  2. cursor shape

    @PankajBhojwani
    PankajBhojwani committed Nov 30, 2020
    1 Configuration menu
    Copy the full SHA
    f4dd69a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. background image works now

    @PankajBhojwani
    PankajBhojwani committed Dec 1, 2020
    1 Configuration menu
    Copy the full SHA
    235bbd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. deduplicate code: UpdateSettings now calls UpdateAppearance

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    1 Configuration menu
    Copy the full SHA
    dc8328d View commit details
    Browse the repository at this point in the history

  2. spell, Cl check

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    d3ad801 View commit details
    Browse the repository at this point in the history

  3. IAppearanceConfig interface in settings model side, color scheme gets… 

    … applied fully
    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    43c6204 View commit details
    Browse the repository at this point in the history

  4. background image parameters

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    2960ba2 View commit details
    Browse the repository at this point in the history

  5. actually use the image params

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    bc12378 View commit details
    Browse the repository at this point in the history

  6. functions for update settings/appearance from ui settings

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    34621c1 View commit details
    Browse the repository at this point in the history

  7. conflict

    @PankajBhojwani
    PankajBhojwani committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    45a9718 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. update with the new converged alignment

    @PankajBhojwani
    PankajBhojwani committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    d9fbe56 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. IControl/CoreAppearance

    @PankajBhojwani
    PankajBhojwani committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    9e1a9f9 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. inheritance step 1?

    @PankajBhojwani
    PankajBhojwani committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    a118fe7 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. placeholder inheritance

    @PankajBhojwani
    PankajBhojwani committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    90025ec View commit details
    Browse the repository at this point in the history

  2. friend struct works

    @PankajBhojwani
    PankajBhojwani committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e0244d5 View commit details
    Browse the repository at this point in the history

  3. not experimental

    @PankajBhojwani
    PankajBhojwani committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    95e679c View commit details
    Browse the repository at this point in the history

  4. color scheme fix

    @PankajBhojwani
    PankajBhojwani committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    6688c3c View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. dont update appearance if no unfocused config

    @PankajBhojwani
    PankajBhojwani committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    9eba7ab View commit details
    Browse the repository at this point in the history

  2. add comments to code

    @PankajBhojwani
    PankajBhojwani committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    698cf41 View commit details
    Browse the repository at this point in the history

  3. update to mock term settings

    @PankajBhojwani
    PankajBhojwani committed Dec 11, 2020
    Configuration menu
    Copy the full SHA
    8194aca View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. begin

    @PankajBhojwani
    PankajBhojwani committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    8b64425 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. everything updates except color scheme?

    @PankajBhojwani
    PankajBhojwani committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    403646f View commit details
    Browse the repository at this point in the history

  2. color scheme fix

    @PankajBhojwani
    PankajBhojwani committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    7b5e04e View commit details
    Browse the repository at this point in the history

  3. dead code

    @PankajBhojwani
    PankajBhojwani committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    21139f5 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary comment

    @PankajBhojwani
    PankajBhojwani committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    7079e60 View commit details
    Browse the repository at this point in the history

  5. format

    @PankajBhojwani
    PankajBhojwani committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    1fc3e8b View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/terminal_settings
    @PankajBhojwani
    PankajBhojwani committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    5151a7f View commit details
    Browse the repository at this point in the history

  2. conflicts

    @PankajBhojwani
    PankajBhojwani committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    25b31d4 View commit details
    Browse the repository at this point in the history

  3. changing base branch conflicts

    @PankajBhojwani
    PankajBhojwani committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    811f796 View commit details
    Browse the repository at this point in the history

  4. updates to get it working again after merge

    @PankajBhojwani
    PankajBhojwani committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    bd6fc9f View commit details
    Browse the repository at this point in the history

  5. AppearanceConfig -> IAppearanceConfig

    @PankajBhojwani
    PankajBhojwani committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    363307b View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. pass unfocused appearance as another IControlSettings

    @PankajBhojwani
    PankajBhojwani committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    155f522 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. remove app appearance config

    @PankajBhojwani
    PankajBhojwani committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    d45439f View commit details
    Browse the repository at this point in the history

  2. remove another reference

    @PankajBhojwani
    PankajBhojwani committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    b3aa5dc View commit details
    Browse the repository at this point in the history

  3. remove IControlAppearance object from IControlSettings

    @PankajBhojwani
    PankajBhojwani committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    e241ade View commit details
    Browse the repository at this point in the history

  4. newline

    @PankajBhojwani
    PankajBhojwani committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    7509ed0 View commit details
    Browse the repository at this point in the history

  5. ok

    @PankajBhojwani
    PankajBhojwani committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    e27a359 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/terminal_settings
    @PankajBhojwani
    PankajBhojwani committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    8d2c583 View commit details
    Browse the repository at this point in the history

  2. pragma warning

    @PankajBhojwani
    PankajBhojwani committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    a288001 View commit details
    Browse the repository at this point in the history

  3. conflict

    @PankajBhojwani
    PankajBhojwani committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    ceb1d00 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. color table fix

    @PankajBhojwani
    PankajBhojwani committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b57ee23 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. remove import

    @PankajBhojwani
    PankajBhojwani committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6ac4249 View commit details
    Browse the repository at this point in the history

  2. fix comment

    @PankajBhojwani
    PankajBhojwani committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    ab36124 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. conflict

    @PankajBhojwani
    PankajBhojwani committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f5974b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/terminal_settings
    @PankajBhojwani
    PankajBhojwani committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    b9ef9f1 View commit details
    Browse the repository at this point in the history

  2. conflict

    @PankajBhojwani
    PankajBhojwani committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    fb63251 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. conflicts

    @PankajBhojwani
    PankajBhojwani committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    ae81a4a View commit details
    Browse the repository at this point in the history

  2. rename unfocusedConfig to unfocusedAppearance

    @PankajBhojwani
    PankajBhojwani committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    422a785 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. update test

    @PankajBhojwani
    PankajBhojwani committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    37b219a View commit details
    Browse the repository at this point in the history

  2. cursor height

    @PankajBhojwani
    PankajBhojwani committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d150eda View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. implement to json and copy appearance

    @PankajBhojwani
    PankajBhojwani committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2cbcd75 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. copy settings and tojson

    @PankajBhojwani
    PankajBhojwani committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    e08fabe View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. const, has value

    @PankajBhojwani
    PankajBhojwani committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    8e5522e View commit details
    Browse the repository at this point in the history

  2. copy appearance works now

    @PankajBhojwani
    PankajBhojwani committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4f63f8d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Merge branch 'main' of https://github.com/microsoft/terminal into dev… 

    …/pabhoj/unfocused_pane
    @PankajBhojwani
    PankajBhojwani committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    e106314 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. fix conflicts

    @PankajBhojwani
    PankajBhojwani committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    4bbc653 View commit details
    Browse the repository at this point in the history

  2. update macro

    @PankajBhojwani
    PankajBhojwani committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    bfabaec View commit details
    Browse the repository at this point in the history

  3. address comments

    @PankajBhojwani
    PankajBhojwani committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    99132d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. fix tests

    @PankajBhojwani
    PankajBhojwani committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    8d577c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. abstract

    @PankajBhojwani
    PankajBhojwani committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9ca0773 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. const

    @PankajBhojwani
    PankajBhojwani committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    1d126e8 View commit details
    Browse the repository at this point in the history

  2. decltype comment

    @PankajBhojwani
    PankajBhojwani committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    acec746 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. first step for default appearance

    @PankajBhojwani
    PankajBhojwani committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    10641af View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. aaaa

    @PankajBhojwani
    PankajBhojwani committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    309f449 View commit details
    Browse the repository at this point in the history

  2. okay just some cleanup left I think

    @PankajBhojwani
    PankajBhojwani committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    32dc8c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. merge main, fix conflict

    @PankajBhojwani
    PankajBhojwani committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    77db627 View commit details
    Browse the repository at this point in the history

  2. ?

    @PankajBhojwani
    PankajBhojwani committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    4d1cdc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. pending discussion

    @PankajBhojwani
    PankajBhojwani committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b0cbf66 View commit details
    Browse the repository at this point in the history

  2. build settings does the work

    @PankajBhojwani
    PankajBhojwani committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0d62955 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @PankajBhojwani
    PankajBhojwani committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    f64646e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. still gotta fix conflicts

    @PankajBhojwani
    PankajBhojwani committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    c7803be View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. struct added

    @PankajBhojwani
    PankajBhojwani committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    79d3d3c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. struct

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    42ac24c View commit details
    Browse the repository at this point in the history

  2. fix update settings

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    c6b72b4 View commit details
    Browse the repository at this point in the history

  3. conflict

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    45447e1 View commit details
    Browse the repository at this point in the history

  4. naming conflicts

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    521e0f0 View commit details
    Browse the repository at this point in the history

  5. retro and pixel to appearance

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    282dfec View commit details
    Browse the repository at this point in the history

  6. format

    @PankajBhojwani
    PankajBhojwani committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    e857304 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. nits

    @PankajBhojwani
    PankajBhojwani committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    95ab9af View commit details
    Browse the repository at this point in the history

  2. deduplicate

    @PankajBhojwani
    PankajBhojwani committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    5c11434 View commit details
    Browse the repository at this point in the history

  3. validate

    @PankajBhojwani
    PankajBhojwani committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    edc0fbe View commit details
    Browse the repository at this point in the history

  4. oops

    @PankajBhojwani
    PankajBhojwani committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    d1335d1 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @PankajBhojwani
    PankajBhojwani committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    12f2ff9 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. address comments

    @PankajBhojwani
    PankajBhojwani committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8fd094c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. add/update comments

    @PankajBhojwani
    PankajBhojwani committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    858a723 View commit details
    Browse the repository at this point in the history

  2. remove constructor from idl

    @PankajBhojwani
    PankajBhojwani committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    581e769 View commit details
    Browse the repository at this point in the history

  3. source profile

    @PankajBhojwani
    PankajBhojwani committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    6b833d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. conflict

    @PankajBhojwani
    PankajBhojwani committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    79039dd View commit details
    Browse the repository at this point in the history

  2. formta

    @PankajBhojwani
    PankajBhojwani committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    112dcf5 View commit details
    Browse the repository at this point in the history

  3. insert parent helper

    @PankajBhojwani
    PankajBhojwani committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    27805e4 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. schema

    @PankajBhojwani
    PankajBhojwani committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5ac87cd View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. 1 return

    @PankajBhojwani
    PankajBhojwani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    61dcf77 View commit details
    Browse the repository at this point in the history

  2. add all parents

    @PankajBhojwani
    PankajBhojwani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    af0b227 View commit details
    Browse the repository at this point in the history

  3. more comments

    @PankajBhojwani
    PankajBhojwani committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    40ef35f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. conflict

    @PankajBhojwani
    PankajBhojwani committed Apr 2, 2021
    1 Configuration menu
    Copy the full SHA
    9fa647e View commit details
    Browse the repository at this point in the history

  2. mock term

    @PankajBhojwani
    PankajBhojwani committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    822fefe View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. address nits

    @PankajBhojwani
    PankajBhojwani committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    d04c557 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. move lock, initialized check

    @PankajBhojwani
    PankajBhojwani committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    e2130e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. remove update appearance call

    @PankajBhojwani
    PankajBhojwani committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    0089065 View commit details
    Browse the repository at this point in the history