Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WIL doc summary #786

Merged
merged 1 commit into from
May 14, 2019
Merged

Fix WIL doc summary #786

merged 1 commit into from
May 14, 2019

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented May 14, 2019

  • "Windows Internal Library" got named "Windows Implementation Library" for its GH release
  • Fixed the links to point to the files in the WIL GH instead of the local copies.
  • Left the rest of this as general guidance to how we use it.

@miniksa
Fix WIL doc summary
4ad7f92 
- "Windows Internal Library" got named "Windows Implementation Library" for its GH release
- Fixed the links to point to the files in the WIL GH instead of the local copies.
- Left the rest of this as general guidance to how we use it.
@miniksa miniksa added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label May 14, 2019
@miniksa miniksa self-assigned this May 14, 2019
carlos-zamora
carlos-zamora approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@miniksa miniksa merged commit 7c6278d into master May 14, 2019
ObsidianPhoenix pushed a commit to ObsidianPhoenix/Terminal that referenced this pull request May 15, 2019
@miniksa @ObsidianPhoenix
Fix WIL doc summary (microsoft#786)
6902632 
- "Windows Internal Library" got named "Windows Implementation Library" for its GH release
- Fixed the links to point to the files in the WIL GH instead of the local copies.
- Left the rest of this as general guidance to how we use it.
@DHowett-MSFT DHowett-MSFT deleted the miniksa-wil-doc branch May 17, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@adiviness adiviness adiviness approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

Assignees

@miniksa miniksa

Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniksa @adiviness @carlos-zamora @DHowett-MSFT