Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3 STABLE ONLY] Unbind togglePaneZoom #7630

Merged
merged 3 commits into from
Sep 18, 2020

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Disable togglePaneZoom as a binding. Remove it from defaults.json and the schema.

References

#7252 - re-enable this binding when this blocking bug is resolved

Validation Steps Performed

Successful deployment

PankajBhojwani
PankajBhojwani previously approved these changes Sep 14, 2020
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Sep 15, 2020
@ghost ghost requested review from zadjii-msft, miniksa and leonMSFT September 15, 2020 16:21
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 15, 2020
@DHowett DHowett changed the base branch from master to release-1.3 September 18, 2020 23:16
@DHowett DHowett dismissed PankajBhojwani’s stale review September 18, 2020 23:16

The base branch was changed.

@DHowett DHowett changed the title Unbind togglePaneZoom [RELEASE 1.3] Unbind togglePaneZoom Sep 18, 2020
@DHowett DHowett force-pushed the dev/cazamor/unbind-pane-zoom branch from a40f686 to 128d86d Compare September 18, 2020 23:18
@DHowett DHowett changed the title [RELEASE 1.3] Unbind togglePaneZoom [1.3 STABLE ONLY] Unbind togglePaneZoom Sep 18, 2020
@DHowett DHowett merged commit 9767abd into release-1.3 Sep 18, 2020
@DHowett DHowett deleted the dev/cazamor/unbind-pane-zoom branch September 18, 2020 23:19
@carlos-zamora
Copy link
Member Author

@DHowett thanks for making this stable only. Still use this in my daily workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Second It's a PR that needs another sign-off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants