-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.3 STABLE ONLY] Unbind togglePaneZoom
#7630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PankajBhojwani
previously approved these changes
Sep 14, 2020
DHowett
reviewed
Sep 15, 2020
DHowett
reviewed
Sep 15, 2020
DHowett
reviewed
Sep 15, 2020
DHowett
requested changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ghost
added
Needs-Author-Feedback
The original author of the issue/PR needs to come back and respond to something
and removed
Needs-Author-Feedback
The original author of the issue/PR needs to come back and respond to something
labels
Sep 15, 2020
DHowett
dismissed
PankajBhojwani’s stale review
September 18, 2020 23:16
The base branch was changed.
DHowett
force-pushed
the
dev/cazamor/unbind-pane-zoom
branch
from
September 18, 2020 23:18
a40f686
to
128d86d
Compare
DHowett
changed the title
[RELEASE 1.3] Unbind
[1.3 STABLE ONLY] Unbind Sep 18, 2020
togglePaneZoom
togglePaneZoom
@DHowett thanks for making this stable only. Still use this in my daily workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Disable
togglePaneZoom
as a binding. Remove it from defaults.json and the schema.References
#7252 - re-enable this binding when this blocking bug is resolved
Validation Steps Performed
Successful deployment