Add serialization error handling to settings projection layer #7576
Conversation
Note to ReviewersFeel free to review this before #7457. It's an awkward size that's...
So I'm fine either way. |
carlos-zamora
force-pushed
the
dev/cazamor/set/winrt-app-obj-top
branch
from
641e1c7
to
1885822
Compare
carlos-zamora
force-pushed
the
dev/cazamor/set/cascadia-settings-warnings
branch
from
98d08a9
to
eecd112
Compare
ghost
closed this
carlos-zamora
changed the base branch from
dev/cazamor/set/winrt-app-obj-top
to
master
| catch (const SettingsException& ex) | ||
| { | ||
| auto settings = winrt::get_self<implementation::CascadiaSettings>(LoadDefaults()); | ||
| settings->_loadError = ex.Error(); | ||
| return *settings; | ||
| } | ||
| catch (const SettingsTypedDeserializationException& e) | ||
| { | ||
| auto settings = winrt::get_self<implementation::CascadiaSettings>(LoadDefaults()); | ||
| std::string_view what{ e.what() }; |
There was a problem hiding this comment.
i'm not in love with the number of copies of this "fall back to the defaults" code there are now. this is interesting ...
it's a process that can fail, and we need a way to claw an object back out of it just to hang errors off of it.
when the consumer gets an error, what is it going to do? call LoadDefaults again?
There was a problem hiding this comment.
Yeah. I could probably get away with just returning a blank CascadiaSettings instead? Especially since the first thing the consumer does is "if loading the settings failed --> load defaults --> display error/warning message"
This is all absolutely awful.
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
removed
the
AutoMerge
|
🎉 Handy links: |
Now that CascadiaSettings is a WinRT object, we need to update the error
handling a bit. Making it a WinRT object limits our errors to be
hresults. So we moved all the error handling down a layer to when we
load the settings object.
Warnings().GetLoadingError().GetSerializationErrorMessage().References
#7141 - CascadiaSettings is a settings object
#885 - this makes ripping out CascadiaSettings into
TerminalSettingsModel much easier
Validation Steps Performed