Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the "crossed-out" graphic rendition attribute #7143

Merged
2 commits merged into from
Aug 1, 2020

Conversation

j4james
Copy link
Collaborator

@j4james j4james commented Aug 1, 2020

This PR adds support for the ANSI crossed-out graphic rendition
attribute, which is enabled by the SGR 9 escape sequence.

Since the majority of the code required for this attribute had already
been implemented, it was just a matter of activating the
GridLines::Strikethrough style in the Renderer::s_GetGridlines
method when the CrossedOut attribute was set.

VALIDATION

There were already some unit tests in place in VtRendererTest and the
ScreenBufferTests, but I've also now extended the SGR tests in
AdapterTest to cover this attribute.

I've manually confirmed the first test case from #6205 now works as
expected in both conhost and Terminal.

Closes #6205

@ghost ghost added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 1, 2020
@j4james j4james marked this pull request as ready for review August 1, 2020 00:29
@j4james
Copy link
Collaborator Author

j4james commented Aug 1, 2020

Note that I've marked this as closing #6205, although there is actually a second test case in that issue that isn't covered by this PR - using a combining long stroke Unicode character to achieve a strikethrough effect. That seems like it should be a completely separate issue, though, and wasn't something that the OP was particularly concerned about anyway.

@DHowett
Copy link
Member

DHowett commented Aug 1, 2020

Yeah, this should close #6205. I'd prefer to track combining characters of all sorts with #1472 😄

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love me a good stackable PR that builds so cleanly on prior work. 😄
Thank you

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 1, 2020
@ghost
Copy link

ghost commented Aug 1, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 17 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ef4aed9 into microsoft:master Aug 1, 2020
@j4james j4james deleted the feature-sgr-strikethrough branch August 8, 2020 20:04
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for strikethrough text in Windows Terminal
3 participants