Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startingDirectory functionality #604

Merged
merged 6 commits into from
May 11, 2019
Merged

Improve startingDirectory functionality #604

merged 6 commits into from
May 11, 2019

Commits on May 9, 2019

  1. Improve startingDirectory functionality 

    This commit adds the `startingDirectory` property to the default-created
`cmd` and `powershell` profiles, with the default value
`%HOMEDRIVE%%HOMEPATH%`.

Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e4ef0cf View commit details
    Browse the repository at this point in the history

  2. Use %USERPROFILE% to replace %HOMEDRIVE%%HOMEPATH% 

    This commit changes `%USERPROFILE%` in the default profiles to
`%HOMEDRIVE%%HOMEPATH%`.

https://stackoverflow.com/posts/36392591/revisions says `%USERPROFILE%`
is better than `%HOMEDRIVE%%HOMEPATH%`, so changed it.

Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 9, 2019
    Configuration menu
    Copy the full SHA
    43e9b9c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2019

  1. Improve startingDirectory functionality 

    This commit adds the `startingDirectory` property to the default-created
`cmd` and `powershell` profiles, with the default value
`%HOMEDRIVE%%HOMEPATH%`.

Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 11, 2019
    Configuration menu
    Copy the full SHA
    37ac537 View commit details
    Browse the repository at this point in the history

  2. Use %USERPROFILE% to replace %HOMEDRIVE%%HOMEPATH% 

    This commit changes `%USERPROFILE%` in the default profiles to
`%HOMEDRIVE%%HOMEPATH%`.

https://stackoverflow.com/posts/36392591/revisions says `%USERPROFILE%`
is better than `%HOMEDRIVE%%HOMEPATH%`, so changed it.

Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 11, 2019
    Configuration menu
    Copy the full SHA
    94ea1d7 View commit details
    Browse the repository at this point in the history

  3. Merge upstream master 

    Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 11, 2019
    Configuration menu
    Copy the full SHA
    e65f8ff View commit details
    Browse the repository at this point in the history

  4. Consolidate constant 

    Refer to the externally defined constant in code.

Signed-off-by: Fred Miller <fghzxm@outlook.com>
    @fghzxm
    fghzxm committed May 11, 2019
    Configuration menu
    Copy the full SHA
    a4e4780 View commit details
    Browse the repository at this point in the history