Remove singleLine copy from Shift+Click, CopyOnSelect #5346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
added
the
Area-TerminalControl
|
@DHowett-MSFT what do you think about this approach? You're probably the most passionate about this feature 😊. I created this PR as a draft to poll your thoughts before we decide on next steps. |
DHowett-MSFT
approved these changes
Apr 13, 2020
zadjii-msft
approved these changes
Apr 14, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This fixes an issue where a shift+click selection with
copyOnSelectenabled would result in copying the content as a single line.PR Checklist
Detailed Description of the Pull Request / Additional comments
I've been thinking a lot about this issue and how it relates to the copy/paste discussions we've been having over the past few weeks. Considering that the majority of users want regular copy, it makes sense to default to that in this case too.
If a user wants to perform a special form of copy, it makes sense that they should use their custom keybinding to accomplish that. This kind of behavior aligns with that kind of philosophy.
Validation Steps Performed
The following scenarios were tested with
copyOnSelectenabled.singleLinedisabled)singleLineenabled)