Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts High DPI scaling to enable differential rendering #5345

Merged
merged 47 commits into from
Apr 22, 2020

Commits on Mar 23, 2020

  1. Configuration menu
    Copy the full SHA
    7e8f039 View commit details
    Browse the repository at this point in the history
  2. it works!

    miniksa committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    b46b5d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    78c1bc1 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Configuration menu
    Copy the full SHA
    39d67e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    777524a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a15af9b View commit details
    Browse the repository at this point in the history
  4. code format

    miniksa committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    ac01c0b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. code format and audit mode.

    miniksa committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    c478983 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Configuration menu
    Copy the full SHA
    f39b352 View commit details
    Browse the repository at this point in the history
  2. Fix selection issues.

    miniksa committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    0d863c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea8e379 View commit details
    Browse the repository at this point in the history
  4. Don't redraw everything. We're competent enough at scrolling in the D…

    …X renderer now to know what the signal means and figure it out.
    miniksa committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    1d72e6b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Report the delta when scroll buffer circles as there is no implicit v…

    …iewport change. Add comments to the TriggerScroll calls to explain why each was chosen.
    miniksa committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    1d51d86 View commit details
    Browse the repository at this point in the history
  2. Invalidate all with retro terminal effects experimental feature turne…

    …d on as the shader is applied at a late stage in the pipeline and causes an unexpected graphics effect with differential drawing.
    miniksa committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    b8c66dd View commit details
    Browse the repository at this point in the history
  3. Don't use incremental drawing parameters on the first frame. Just use…

    … the old Present method.
    miniksa committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    1e5e4eb View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    46e526c View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Remove unused constructor in float. Add scale tests to Rectangle (rem…

    …ove MUL/DIV ones). Add scale test to point.
    miniksa committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f11c7a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    162b516 View commit details
    Browse the repository at this point in the history
  3. change to constexpr

    miniksa committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    45f8144 View commit details
    Browse the repository at this point in the history
  4. GetClient for composition now uses size scale factor directly (and I …

    …implemented scale on til::size mostly as a copy of til::point's implementation and copied the test.)
    miniksa committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    351dc9c View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Adjust the present1/present logic so it will retry if present1 fails …

    …to maintain robustness.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    d42f609 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e060e6 View commit details
    Browse the repository at this point in the history
  3. Fix selection invalidation issues. This was always broken but the nat…

    …ure of union rect invalidation meant it was never a problem before.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    4eddc8d View commit details
    Browse the repository at this point in the history
  4. Fix issue with algorithm around re-using known previous viewport as r…

    …estriction area because it isn't populated until the first scroll operation.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f22577d View commit details
    Browse the repository at this point in the history
  5. code format

    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    f4b39ec View commit details
    Browse the repository at this point in the history
  6. Use GDI Classic measuring mode to eliminate blended half-pixels at th…

    …e bottom of characters on every other line when rendering High DPI text.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    8abf479 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d0e6dd1 View commit details
    Browse the repository at this point in the history
  8. Disable incremental for High DPI as it doesn't work with the implicit…

    … render target scaling.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    b06720a View commit details
    Browse the repository at this point in the history
  9. Put natural rendering back.

    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    1207e80 View commit details
    Browse the repository at this point in the history
  10. Actually lock in selection code so it doesn't pull the rug out from u…

    …nder the renderer while it's operating.
    miniksa committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    24ecd5b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Adjust DxRenderer and TerminalControl to change the area of concern o…

    …ver DPI from the D2DRenderTarget into the font choice itself.
    miniksa committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    0d5cfc7 View commit details
    Browse the repository at this point in the history
  2. Remove block on incremental rendering for High DPI. Remove scale comp…

    …ensations in calculating invalid areas as the font has already adjusted to compensate.
    miniksa committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    e476e5c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8b6b72 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05bd203 View commit details
    Browse the repository at this point in the history
  5. code format

    miniksa committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    f4ddf1f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d330a00 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    767f491 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Configuration menu
    Copy the full SHA
    9a5d257 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Configuration menu
    Copy the full SHA
    ca7ccf3 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2020

  1. Configuration menu
    Copy the full SHA
    79fdf25 View commit details
    Browse the repository at this point in the history
  2. Various Differential Drawing fixes for #5345 (#5427)

    * This seems to work, but can it avoid resizing the buffer twice on a DPI change?
    
    * Add a doc comment that should have been in the previous commit
    
    * Remove some dead code I didn't end up needing
    
    * convert TSFInputControl::_RedrawCanvas to use til wherever possible
    
      This is just here to help me debug
    
    * I think this works fine on high-dpi for latin, cyrillic, emoji, chinese
    
    * This _actaully_ works and displays the composition correctly. Needs comments
    
    * Clean up this code significantly
    
    * This does in fact work
    
    * Skip one of the two resizes during a DPI scale change.
    
    * This definitely fixes the gutters, but lets try to be more surgical about it
    
    * Add some comments
    
    * This fixes the 'vim open in an inactive tab' bug I was seeing, but I might be able to do it without reverting the double resize
    
    * More good good til helpers
    
    * rewrite TermControl::_GetTerminalPosition, this might all be wrong though.
    
    * Do pointer event scaling in DIPs
    
    * Largely cleanup, but also add a TODO as it's almost 5pm here
    
    * Remove unused code, comments about receiving a useless ScaleChanged event
    
    * Update the font size in response to a settings reload
    
    * Fix blanking vim on a settings update
    
    * good bot
    
    * Immediately tell the VT Engine about the new viewport size when we resize conpty
    
    * fix the bitmap::all() function so we can actually use it
    
    (cherry picked from commit ba1a8a34292180cae10c135743ecd94b1da6f286)
    
    * maybe I should let it finish building before I commit
    
    (cherry picked from commit 98cdbeca349acb55c5b5aef1d96206a8fa7b62e4)
    
    * Hey what's this doing here
    
    * Account for IME wrapping
    zadjii-msft committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    cbe389f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acb9f4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e11d6a7 View commit details
    Browse the repository at this point in the history
  5. Typo.

    miniksa committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    3d4b978 View commit details
    Browse the repository at this point in the history
  6. Code format.

    miniksa committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    ec614ab View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4094d9b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4337cf5 View commit details
    Browse the repository at this point in the history