Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the virtual bottom location if the cursor moves below it #5317

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Update the virtual bottom location if the cursor moves below it #5317

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2db562
Update the virtual bottom location if the cursor moves below that point.
j4james Apr 10, 2020
6b8fac1
Add a unit test to confirm the virtual bottom is being updated.
j4james Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/host/screenInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,12 @@ void SCREEN_INFORMATION::SetCursorDBMode(const bool DoubleCursor)

cursor.SetPosition(Position);

// If the cursor has moved below the virtual bottom, the bottom should be updated.
if (Position.Y > _virtualBottom)
{
_virtualBottom = Position.Y;
}

// if we have the focus, adjust the cursor state
if (gci.Flags & CONSOLE_HAS_FOCUS)
{
Expand Down