Add support for the DSR-OS operating status report #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subtype is dispatched correctly.
…ppropriate response.
zadjii-msft
approved these changes
Apr 9, 2020
zadjii-msft
added
Area-VT
DHowett-MSFT
approved these changes
Apr 9, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This adds support for the VT escape sequence that requests the terminal's operating status. There is no attempt to actually verify the status of the app, though. We always return a response indicating a good operating condition (the same as most terminal emulators).
PR Checklist
Detailed Description of the Pull Request / Additional comments
This required an update to the
OutputStateMachineEngineto accept theDSR-OStype, since it only dispatches types that it recognises (I think that's unnecessary, but that's an issue for another day).The actual processing of the request is handled in the
AdaptDispatchclass, where it simply responds with a hard coded sequence (CSI 0 n), indicating a good operating condition.Validation Steps Performed
I've added unit tests to confirm that the request is dispatched correctly, and the appropriate response is returned. I've also manually confirmed that the test of the Device Status Report in Vttest is now succeeding.