Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'requestedTheme' to 'theme' #5265

Merged
2 commits merged into from
Apr 7, 2020
Merged

Rename 'requestedTheme' to 'theme' #5265

2 commits merged into from
Apr 7, 2020

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Renames the requestedTheme global setting to theme. Propagates updates to...

  • schema
  • doc
  • defaults.json
  • universal-defaults.json

PR Checklist

Validation Steps Performed

theme Success?
system ✔
light ✔
dark ✔

But we really know that dark is the one we care about here 😉

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Apr 7, 2020
@cinnamon-msft cinnamon-msft self-requested a review April 7, 2020 19:02
@carlos-zamora
Copy link
Member Author

FULL TEAM SIGNOFF!! 🎉🎊🥳

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 7, 2020
@ghost
Copy link

ghost commented Apr 7, 2020

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7c7db79 into master Apr 7, 2020
@ghost ghost deleted the dev/cazamor/settings/theme branch April 7, 2020 19:14
@DHowett-MSFT DHowett-MSFT mentioned this pull request Apr 22, 2020
Closed
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 22, 2020
Closed
@zadjii-msft zadjii-msft mentioned this pull request May 20, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@cinnamon-msft cinnamon-msft cinnamon-msft approved these changes

@leonMSFT leonMSFT leonMSFT approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename requestedTheme to theme
6 participants
@carlos-zamora @DHowett-MSFT @miniksa @zadjii-msft @cinnamon-msft @leonMSFT