Relax locking around the swapchain #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terminal lock is really only for the terminal; since the renderer is fully owned by the control, not the Terminal, and we'll only be receiving swap chain events after we register them during initialization, we don't need to lock before _or_ after firing off the coroutine. Fixes #5203.
zadjii-msft
approved these changes
Apr 3, 2020
| } | ||
| } | ||
|
|
||
| // This event is only registered during terminal initialization, |
There was a problem hiding this comment.
Suggested change
| // This event is only registered during terminal initialization, | |
| // See GH#5203 | |
| // This event is only registered during terminal initialization, |
Because otherwise I'd forget why this is okay
5 tasks
|
This may not be entirely correct. |
|
I was wrong. It is not the cause of the crash in 5185. |
You mean #5203? |
|
@carlos-zamora no, I mean #5185. |
carlos-zamora
approved these changes
Apr 3, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The terminal lock is really only for the terminal; since the renderer is
fully owned by the control, not the Terminal, and we'll only be
receiving swap chain events after we register them during
initialization, we don't need to lock before or after firing off the
coroutine.
PR Checklist
Validation Steps Performed
Manual validation.