Update default settings.json experience #5217

carlos-zamora · 2020-04-02T01:21:05Z

Summary of the Pull Request

Add comments and settings to settings.json for discoverability.

PR Checklist

carlos-zamora · 2020-04-02T01:24:22Z

I added a bunch of links to https://aka.ms/terminal-documentation. I think we agreed that it would be better to have links to more relevant spots but those need to be created.

@cinnamon-msft could you create those aka.ms links so that I add them in? Or just let me know what to do here.

@DHowett-MSFT Should we be using FW links here instead? I think we said no, but I want to make double-check.

zadjii-msft

I think we want aka.ms links here, but yea we should probably get more of them

zadjii-msft · 2020-04-02T13:30:37Z

@msftbot make sure @cinnamon-msft signs off on this

ghost · 2020-04-02T13:30:41Z

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

I'll only merge this pull request if it's approved by @cinnamon-msft

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

src/cascadia/TerminalApp/userDefaults.json

cinnamon-msft · 2020-04-02T16:36:28Z

Given the state of our documentation, I can't give specific links. I think just the one aka.ms documentation link is fine.
Also, yes these are aka.ms links, not fwlinks. :)

DHowett-MSFT · 2020-04-02T16:37:52Z

I don’t think there is value in having a link above every section if every link is just the same link. It’s like saying “look here for specific documentation. NATCH! Got you, here’s the landing page.”

src/cascadia/TerminalApp/userDefaults.json

cinnamon-msft · 2020-04-03T16:43:06Z

I didn't realize we didn't have "requestedTheme" already in the settings.json file. What are your thoughts on adding this setting as well? @microsoft/windows-console-team

src/cascadia/TerminalApp/userDefaults.json

DHowett-MSFT · 2020-04-03T17:22:50Z

Hey, should we rename requestedTheme? It doesn't make a lot of sense ... it's more of an applicationTheme.

zadjii-msft · 2020-04-03T17:25:55Z

should we rename requestedTheme? It doesn't make a lot of sense ... it's more of an applicationTheme.

This is probably fine, and would probably still be fine with #3327. I'm mildly worried that renaming the setting now means we're breaking everyone who's got it set currently, unless they manually change it, because we won't be supporting migrating from the old value. We're also breaking other things too so idk

cinnamon-msft · 2020-04-03T18:32:59Z

I'm okay with changing it.

DHowett-MSFT

NAK on the indentattion change unless you can explain what it is and why it is and where it came from, or fix the code to make it do 2 spaces by default.

src/cascadia/TerminalApp/userDefaults.json

DHowett-MSFT · 2020-04-03T19:02:35Z

src/cascadia/TerminalApp/userDefaults.json

+  [
+    // Copy and paste are bound to Ctrl+Shift+C and Ctrl+Shift+V in your defaults.json
+    // These bindings additionally bind them to Ctrl+C and Ctrl+V
+    // To learn more about selection, visit https://aka.ms/terminal-selection


I don't necessarily think selection warrants its own URL callout

I was imagining the page would include the following:

using the mouse and non-rebindable modifiers

HTML Copy

SingleLine

how selection works with VTMM

Since HTML Copy is being discussed in #5212, I'm wondering if this will help with the discoverability there?

But we are just in the keybindings section so some of that isn't all that relevant. Whatcha think? Is this a valid concern?

src/cascadia/TerminalApp/userDefaults.json

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

src/cascadia/TerminalApp/userDefaults.json

This pull request introduces unexpanded variables (`%DEFAULT_PROFILE%`, `%VERSION%` and `%PRODUCT%`) to the user settings template and code to expand them. While doing this, I ran into a couple things that needed to widen from accepting strings to accepting string views. I also had to move application name and version detection up to AppLogic and expose the AppLogic singleton. The dynamic profile generation logic had to be moved to before we inject the templated variables, as the new default profile depends on the generated dynamic profiles. References #5189, #5217 (because it has a dependency on `VERSION` and `PRODUCT`). ## PR Checklist * [x] Closes #2721 * [x] CLA signed * [x] Tests added/passed * [ ] Requires documentation to be updated * [x] I've discussed this with core contributors already ## Validation Steps Performed Deleted my settings and watched them regenerate.

src/cascadia/TerminalApp/userDefaults.json

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

…microsoft/Terminal into dev/cazamor/settings-copy-pasta

ghost · 2020-04-09T23:14:00Z

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2020-04-22T17:15:54Z

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

carlos-zamora added 3 commits April 1, 2020 17:56

add settings for discoverability

e49190f

add copy/pasta note

3a07226

add doc link for global settings

7b953d6

carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Area-Settings Issues related to settings and customizability, for console or terminal labels Apr 2, 2020

carlos-zamora requested review from DHowett-MSFT and cinnamon-msft April 2, 2020 01:21

carlos-zamora marked this pull request as ready for review April 2, 2020 01:24

zadjii-msft approved these changes Apr 2, 2020

View reviewed changes

ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 2, 2020

cinnamon-msft suggested changes Apr 2, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Show resolved Hide resolved

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 2, 2020

cook some updates with cinnamon

f33abce

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 2, 2020

cinnamon-msft suggested changes Apr 2, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 2, 2020

DHowett-MSFT removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 2, 2020

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 2, 2020

miniksa reviewed Apr 3, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Show resolved Hide resolved

miniksa reviewed Apr 3, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Show resolved Hide resolved

add more comments!

0cdb80f

indent = 4 spaces

9a8dcca

DHowett-MSFT suggested changes Apr 3, 2020

View reviewed changes

ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 3, 2020

remove disclaimer

7a4d999

DHowett-MSFT reviewed Apr 3, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Show resolved Hide resolved

Dev-ing with Dustin

d532b4e

DHowett-MSFT reviewed Apr 3, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

Take Dustin's commit and claim it as my own

3942cac

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

carlos-zamora removed the Area-User Interface Issues pertaining to the user interface of the Console or Terminal label Apr 6, 2020

leonMSFT reviewed Apr 6, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

DHowett-MSFT mentioned this pull request Apr 6, 2020

Patch the default profile and version into the settings template #5232

Merged

5 tasks

carlos-zamora added 2 commits April 8, 2020 10:02

merge master

0843d15

Leon's comments

b125e25

carlos-zamora commented Apr 8, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

carlos-zamora and others added 2 commits April 9, 2020 10:16

add "singleLine" to copy

eeeb052

Merge branch 'master' into dev/cazamor/settings-copy-pasta

3998446

DHowett-MSFT approved these changes Apr 9, 2020

View reviewed changes

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/userDefaults.json Outdated Show resolved Hide resolved

Add missing space

48011f6

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

cinnamon-msft approved these changes Apr 9, 2020

View reviewed changes

Merge branch 'dev/cazamor/settings-copy-pasta' of https://github.com/…

8225f63

…microsoft/Terminal into dev/cazamor/settings-copy-pasta

carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 9, 2020

ghost merged commit c65de31 into master Apr 9, 2020

ghost deleted the dev/cazamor/settings-copy-pasta branch April 9, 2020 23:21

This was referenced Apr 22, 2020

Include Ctrl+C, Ctrl+V keybindings by default #3058

Closed

Add comments and settings to settings.json for discoverability #5188

Closed

Add ctrl+c/ctrl+v to settings.json #5187

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default settings.json experience #5217

Update default settings.json experience #5217

carlos-zamora commented Apr 2, 2020

carlos-zamora commented Apr 2, 2020 •

edited

Loading

zadjii-msft left a comment

zadjii-msft commented Apr 2, 2020

ghost commented Apr 2, 2020

cinnamon-msft commented Apr 2, 2020

DHowett-MSFT commented Apr 2, 2020

cinnamon-msft commented Apr 3, 2020

DHowett-MSFT commented Apr 3, 2020

zadjii-msft commented Apr 3, 2020

cinnamon-msft commented Apr 3, 2020

DHowett-MSFT left a comment

DHowett-MSFT Apr 3, 2020

carlos-zamora Apr 3, 2020

ghost commented Apr 9, 2020

ghost commented Apr 22, 2020

Update default settings.json experience #5217

Update default settings.json experience #5217

Conversation

carlos-zamora commented Apr 2, 2020

Summary of the Pull Request

PR Checklist

carlos-zamora commented Apr 2, 2020 • edited Loading

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft commented Apr 2, 2020

ghost commented Apr 2, 2020

cinnamon-msft commented Apr 2, 2020

DHowett-MSFT commented Apr 2, 2020

cinnamon-msft commented Apr 3, 2020

DHowett-MSFT commented Apr 3, 2020

zadjii-msft commented Apr 3, 2020

cinnamon-msft commented Apr 3, 2020

DHowett-MSFT left a comment

Choose a reason for hiding this comment

DHowett-MSFT Apr 3, 2020

Choose a reason for hiding this comment

carlos-zamora Apr 3, 2020

Choose a reason for hiding this comment

ghost commented Apr 9, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Apr 22, 2020

carlos-zamora commented Apr 2, 2020 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.