Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename copy keybinding arg #5216

Merged
3 commits merged into from
Apr 2, 2020
Merged

Rename copy keybinding arg #5216

3 commits merged into from
Apr 2, 2020

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

TrimWhitespace is misleading. So it is now renamed as 'singleLine'. If true, it comes out as a single line! That makes more sense!

PR Checklist

Validation Steps Performed

Attempted the keybinding with both settings (and none set).
Attempted mouse copy with and without shift.

@carlos-zamora carlos-zamora added the Area-Settings Issues related to settings and customizability, for console or terminal label Apr 2, 2020
doc/cascadia/SettingsSchema.md Outdated Show resolved Hide resolved
Co-Authored-By: Mike Griese <migrie@microsoft.com>
@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 2, 2020
@ghost
Copy link

ghost commented Apr 2, 2020

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 084b48a into master Apr 2, 2020
@ghost ghost deleted the dev/cazamor/settings-cleanup branch April 2, 2020 23:10
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out copyWith{,out}Newlines, perhaps rename Keybinding Arg for Copy
3 participants