Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore from minimized properly when "auto-hide taskbar" is enabled #5213

Merged
2 commits merged into from
Apr 1, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

When we're restoring from minimized, that MonitorFromWindow call is returning null. Curious that we're getting null here, when MSDN states:

If the window is currently minimized, MonitorFromWindow uses the rectangle of the window before it was minimized.

Turns out, MONITOR_DEFAULTTONEAREST just fixes this.

References

PR Checklist

Validation Steps Performed

Verified manually

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Apr 1, 2020
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Thanks.

@DHowett-MSFT
Copy link
Contributor

@msftbot merge this in like 4 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 1, 2020
@ghost
Copy link

ghost commented Apr 1, 2020

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 01 Apr 2020 19:18:02 GMT, which is in 4 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 584e449 into master Apr 1, 2020
@ghost ghost deleted the dev/migrie/b/5209-big-from-smol branch April 1, 2020 21:19
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring a maximized Terminal with an auto-hide taskbar hides the taskbar
3 participants