Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add a spec for the change to formatted copying #5212
doc: add a spec for the change to formatted copying #5212
Changes from 13 commits
e90193c
b691666
fa1e65b
061bd6a
43a0522
fce8895
7f62273
ff82a35
fb5ddc2
16f23a2
a9e0147
ac55620
9c39283
4953f54
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1553 - We should just treat
Alt
like we do withShift
in VTMM. It's a non-rebindable keybinding until then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait didn't we decide on a combo of both 2 & 3?
We do the global setting now, as a boolean, because that's easy. (This is 2a)
We can then update that to additionally accept an array in the future, where
true
==[html, rtf, plain]
andfalse
==[plain]
(This is 2b)Then, we could further add an optional parameter to the copy
ShortcutAction
. If it's set, we'll copy with the provided formatting. Otherwise, we'll use the value of the global setting? (This is 3)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I guess this is kinda what it does say, I just didn't immediately parse that this was a phased implementation plan