Set DxRenderer non-text alias mode #5149

carlos-zamora · 2020-03-27T20:39:18Z

There are two antialias modes that can be set on the ID2D1RenderTarget:

one for text/glyph drawing [1]
one for everything else [2]
We had to configure that in the RenderTarget.

Additionally, when clipping the background color rect, we need to make
sure that's aliased too. [3]

References

[1] ID2D1RenderTarget::SetTextAntialiasMode
https://docs.microsoft.com/en-us/windows/win32/api/d2d1/nf-d2d1-id2d1rendertarget-settextantialiasmode
[2] ID2D1RenderTarget::SetAntialiasMode
https://docs.microsoft.com/en-us/windows/win32/api/d2d1/nf-d2d1-id2d1rendertarget-setantialiasmode)
[3] ID2D1CommandSink::PushAxisAlignedClip
https://docs.microsoft.com/en-us/windows/win32/api/d2d1_1/nf-d2d1_1-id2d1commandsink-pushaxisalignedclip)

Validation

Open and interact with midnight commander with the display scaling set
to...

100%
125%
150%
175%
200%

Closes #3626

zadjii-msft · 2020-03-27T21:46:35Z

@msftbot make sure @miniksa signs off on this one

ghost · 2020-03-27T21:46:40Z

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

I'll only merge this pull request if it's approved by @miniksa

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

zadjii-msft

This looks fine to me from the pages you've linked

DHowett-MSFT · 2020-03-27T22:07:48Z

Your pull request body looks ugly now because I edited it, but it will look better as a commit :)

Since this is a single commit, please merge it manually and copy the title/body of the PR

miniksa

I want you to leave the comments right next to all the places that this is set explaining why it is set the way it is and what the intent was for the next person to stumble through.

miniksa · 2020-03-27T23:06:22Z

(I will approve when you do that. Or rather, I will now but please do not auto-merge this until Carlos puts those comments into the code.)

ghost · 2020-03-27T23:29:05Z

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 10 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

carlos-zamora · 2020-03-28T00:13:11Z

@msftbot merge this in 2 minutes

ghost · 2020-03-28T00:13:13Z

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

I won't merge this pull request until after the UTC date Sat, 28 Mar 2020 00:15:13 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

miniksa · 2020-03-28T04:36:48Z

Huh, @carlos-zamora, I just realized this was a perf improvement too because aliased drawing is way faster than not.

carlos-zamora · 2020-03-28T04:44:58Z

Ooh. Be sure to rebase when you do perf traces.

There are two antialias modes that can be set on the ID2D1RenderTarget: - one for text/glyph drawing [1] - one for everything else [2] We had to configure that in the RenderTarget. Additionally, when clipping the background color rect, we need to make sure that's aliased too. [3] ## References [1] ID2D1RenderTarget::SetTextAntialiasMode https://docs.microsoft.com/en-us/windows/win32/api/d2d1/nf-d2d1-id2d1rendertarget-settextantialiasmode [2] ID2D1RenderTarget::SetAntialiasMode https://docs.microsoft.com/en-us/windows/win32/api/d2d1/nf-d2d1-id2d1rendertarget-setantialiasmode) [3] ID2D1CommandSink::PushAxisAlignedClip https://docs.microsoft.com/en-us/windows/win32/api/d2d1_1/nf-d2d1_1-id2d1commandsink-pushaxisalignedclip) ## Validation Open and interact with midnight commander with the display scaling set to... - 100% - 125% - 150% - 175% - 200% Closes #3626

Improve wide glyph support in UIA (GH-4946) Add enhanced key support for ConPty (GH-5021) Set DxRenderer non-text alias mode (GH-5149) Reduce CursorChanged Events for Accessibility (GH-5196) Add more object ID tracing for Accessibility (GH-5215) Add SS3 cursor key encoding to ConPty (GH-5383) UIA: Prevent crash from invalid UTR endpoint comparison (GH-5399) Make CodepointWidthDetector::GetWidth faster (CC-3727) add til::math, use it for float conversions to point, size (GH-5150) Add support for renderer backoff, don't FAIL_FAST on 3x failures, add UI (GH-5353) Fix a deadlock and a bounding rects issue in UIA (GH-5385) Don't duplicate spaces from potentially-wrapped EOL-deferred lines (GH-5398) Reimplement the VT tab stop functionality (CC-5173) Clamp parameter values to a maximum of 32767. (CC-5200) Prevent the cursor type being reset when changing the visibility (CC-5251) Make RIS switch back to the main buffer (CC-5248) Add support for the DSR-OS operating status report (CC-5300) Update the virtual bottom location if the cursor moves below it (CC-5317) ci: run spell check in CI, fix remaining issues (CC-4799) (CC-5352) Set Cascadia Code as default font (GH-5121) Show a double width cursor for double width characters (GH-5319) Delegate all character input to the character event handler (CC-4192) Update til::bitmap to use dynamic_bitset<> + libpopcnt (GH-5092) Merged PR 4465022: [Git2Git] Merged PR 4464559: Console: Ingest OSS changes up to e055079 Correct scrolling invalidation region for tmux in pty w/ bitmap (GH-5122) Render row-by-row instead of invalidating entire screen (GH-5185) Make conechokey use ReadConsoleInputW by default (GH-5148) Manually pass mouse wheel messages to TermControls (GH-5131) This fixes C-M-space for WSL but not for Win32, but I'm not sure there's a problem in Win32 quite yet. (GH-5208) Fix copying wrapped lines by implementing better scrolling (GH-5181) Emit lines wrapped due to spaces at the end correctly (GH-5294) Remove unneeded whitespace (CC-5162)

ghost · 2020-04-22T17:12:09Z

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

Set DxRenderer non-text alias mode

8a0bb71

carlos-zamora added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Mar 27, 2020

carlos-zamora requested a review from miniksa March 27, 2020 20:39

ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 27, 2020

zadjii-msft approved these changes Mar 27, 2020

View reviewed changes

DHowett-MSFT removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 27, 2020

miniksa requested changes Mar 27, 2020

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 27, 2020

miniksa approved these changes Mar 27, 2020

View reviewed changes

add comment

8c4228c

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 27, 2020

DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 27, 2020

ghost merged commit 28d108b into master Mar 28, 2020

ghost deleted the dev/cazamor/bugfix-mc-lines branch March 28, 2020 00:15

zadjii-msft mentioned this pull request Apr 14, 2020

DPI Setting will break the characters should be connected #5349

Closed

zadjii-msft mentioned this pull request Apr 16, 2020

Gaps between characters in 'mc' when used with 150% display scaling #5382

Closed

ghost mentioned this pull request Apr 22, 2020

black lines in background when using midnight commander or neovim #3626

Closed

This was referenced Apr 22, 2020

Font rendering issues in Terminal #610

Closed

Remember to have block and line drawing characters fill their cells properly #455

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set DxRenderer non-text alias mode #5149

Set DxRenderer non-text alias mode #5149

carlos-zamora commented Mar 27, 2020 •

edited by DHowett-MSFT

Loading

zadjii-msft commented Mar 27, 2020

ghost commented Mar 27, 2020

zadjii-msft left a comment

DHowett-MSFT commented Mar 27, 2020

miniksa left a comment

miniksa commented Mar 27, 2020

ghost commented Mar 27, 2020

carlos-zamora commented Mar 28, 2020

ghost commented Mar 28, 2020

miniksa commented Mar 28, 2020

carlos-zamora commented Mar 28, 2020

ghost commented Apr 22, 2020

Set DxRenderer non-text alias mode #5149

Set DxRenderer non-text alias mode #5149

Conversation

carlos-zamora commented Mar 27, 2020 • edited by DHowett-MSFT Loading

References

Validation

zadjii-msft commented Mar 27, 2020

ghost commented Mar 27, 2020

zadjii-msft left a comment

Choose a reason for hiding this comment

DHowett-MSFT commented Mar 27, 2020

miniksa left a comment

Choose a reason for hiding this comment

miniksa commented Mar 27, 2020

ghost commented Mar 27, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

carlos-zamora commented Mar 28, 2020

ghost commented Mar 28, 2020

miniksa commented Mar 28, 2020

carlos-zamora commented Mar 28, 2020

ghost commented Apr 22, 2020

carlos-zamora commented Mar 27, 2020 •

edited by DHowett-MSFT

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.