Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to account for the size the padding _will be_ scaled to #5091

Merged
1 commit merged into from
Mar 23, 2020
Merged

Make sure to account for the size the padding _will be_ scaled to #5091

1 commit merged into from
Mar 23, 2020

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) labels Mar 23, 2020
DHowett-MSFT
DHowett-MSFT approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol.

@DHowett-MSFT DHowett-MSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 23, 2020
@ghost
Copy link

ghost commented Mar 23, 2020

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 51 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett-MSFT DHowett-MSFT added the Needs-Second It's a PR that needs another sign-off label Mar 23, 2020
@ghost ghost requested review from miniksa, carlos-zamora and leonMSFT March 23, 2020 22:07
@DHowett-MSFT
Copy link
Contributor

@msftbot merge this in 2 minutes

@ghost
Copy link

ghost commented Mar 23, 2020

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Mon, 23 Mar 2020 22:09:19 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit e055079 into master Mar 23, 2020
@ghost ghost deleted the dev/migrie/b/2061-not-the-PADDING branch March 23, 2020 22:24
@zadjii-msft zadjii-msft mentioned this pull request Apr 21, 2020
Closed
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 22, 2020
Closed
@iravikds
Copy link

Is the fix only available in the preview build? If yes then when will this be updated to the non preview build?

@DHowett
Copy link
Member

DHowett commented Jun 17, 2020

@RaviiKmr This was fixed and released before 1.0 came out, so it should be in 1.0. What makes you think you're seeing the issue fixed by this PR?

@iravikds
Copy link

@DHowett Sorry, I didn't see that.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal is starting up at a size that's different from initialRows/initialCols
5 participants
@zadjii-msft @DHowett-MSFT @iravikds @DHowett @carlos-zamora