Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the case sensitivity button in search on High Contrast #5088

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Fix the case sensitivity button in search on High Contrast #5088

merged 3 commits into from
Mar 23, 2020

Conversation

DHowett-MSFT
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT commented Mar 23, 2020 •
edited
Loading

Because the Path inside the case sensitivity button is not text, it wasn't getting themed by the Xaml runtime's text style.

zadjii-msft
zadjii-msft approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, sure, but I'd probably change the HC in the title, because I didn't get that meant "High Contrast"

@DHowett-MSFT DHowett-MSFT changed the title Fix the case sensitivity button in search in HC Fix the case sensitivity button in search in High Contrast Mar 23, 2020
@DHowett-MSFT
Copy link
Contributor Author

name change: done

@DHowett-MSFT DHowett-MSFT changed the title Fix the case sensitivity button in search in High Contrast Fix the case sensitivity button in search on High Contrast Mar 23, 2020
@DHowett-MSFT DHowett-MSFT merged commit f088ae6 into master Mar 23, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/duhowett/hc-search-2 branch March 23, 2020 18:24
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @DHowett