Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to InvalidateAll on a resize #5046

Merged
2 commits merged into from
Mar 20, 2020
Merged

Make sure to InvalidateAll on a resize #5046

2 commits merged into from
Mar 20, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Seriously just read the code on this one, it's so incredibly obvious what I did wrong

References

Regressed with #4741

PR Checklist

@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Mar 20, 2020
DHowett-MSFT
DHowett-MSFT approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@zadjii-msft
Update src/cascadia/TerminalCore/Terminal.cpp
133785e 
Let's just yolo this in from github
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 20, 2020
@ghost
Copy link

ghost commented Mar 20, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 55 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett-MSFT
Copy link
Contributor

@msftbot merge this in 5 minutes

@ghost
Copy link

ghost commented Mar 20, 2020

Hello @DHowett-MSFT!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 20 Mar 2020 23:50:40 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 0f82811 into master Mar 20, 2020
@ghost ghost deleted the dev/migrie/b/5029-invalidate-all-on-resize branch March 20, 2020 23:51
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Apr 22, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt+ Enter rendering error
3 participants
@zadjii-msft @DHowett-MSFT @carlos-zamora