Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ConPTY to use til::bitmap #5024

Merged
28 commits merged into from
Mar 23, 2020
Merged

Move ConPTY to use til::bitmap #5024

28 commits merged into from
Mar 23, 2020

Commits on Mar 17, 2020

  1. Configuration menu
    Copy the full SHA
    d637178 View commit details
    Browse the repository at this point in the history
  2. Make bitmap tests. Add supplemental helpers to rectangle and some, al…

    …so add associated tests.
    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    70567d4 View commit details
    Browse the repository at this point in the history
  3. Add tests for setting/resetting points/rectangles out of bounds. Add …

    …support method for checking if rectangle contains another, add test for that too.
    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    69b44ae View commit details
    Browse the repository at this point in the history
  4. code format pass.

    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    fca07fa View commit details
    Browse the repository at this point in the history
  5. Don't include stuff at the top of bitmap. Don't use reserved naming f…

    …or iterator. Fix unsigned issues for x86.
    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    79d1f33 View commit details
    Browse the repository at this point in the history
  6. Fix comment

    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    81af5aa View commit details
    Browse the repository at this point in the history
  7. SA fixes.

    miniksa committed Mar 17, 2020
    Configuration menu
    Copy the full SHA
    09139c4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    43f952c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. make bitmap track a rectangle inside. remove empty and add bitset met…

    …hods of all/any/none. also add convenience one() method in prediction of what conpty will be looking for.
    miniksa committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    de20c5a View commit details
    Browse the repository at this point in the history
  2. Some frees members, some comments about the rectangle iterator and mo…

    …ve it to details namespace.
    miniksa committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    a86b8fa View commit details
    Browse the repository at this point in the history
  3. Make resize work and add tests. Add constructors that let you allocat…

    …e a bitmap already filled. Generalize the bit checking method in the tests.
    miniksa committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    c4df795 View commit details
    Browse the repository at this point in the history
  4. Static analysis pass.

    miniksa committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    824657f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e3fe53d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d7cf7d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Add run caching to bitmap, make iterator into real input iterator so …

    …it fits nicely into vector emplace, start using bitmap in ConPTY (Vt renderer).
    miniksa committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    83e28f9 View commit details
    Browse the repository at this point in the history
  2. Set up string printing for til types, use that inside the TAEF string…

    … printing. Update VT tracing to use the same strings. Roll out bitmap through most of VT.
    miniksa committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    d705527 View commit details
    Browse the repository at this point in the history
  3. Operators on rectangle with points and sizes, operators between point…

    …s and sizes, translation operator on the bitmap. A ton of tests for all that behavior. Replacing the rest of the VT renderer stuff with the invalidation map.
    miniksa committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    95b9b85 View commit details
    Browse the repository at this point in the history
  4. finish xterm engine changes, make tests work again with the new inval…

    …idation, run codeformat pass.
    miniksa committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    31eadef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    873a612 View commit details
    Browse the repository at this point in the history
  6. SA pass and code format.

    miniksa committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    0651df1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cf06e97 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    59bfce1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a48919e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Fix the vt renderer tests to use the correct expected invalid rectang…

    …les (inclusive/exclusive bug.) Fix one of the tests to not be comparing to internal details based on a 0-size exclusive circumstance that only worked with or-rect. Fix importing of til for unit tests in the library includes so the WEX/TAEF templates show up appropriately (cascaded to changing renderervt.unittest lib compilation to use shared testing props so it works too.)
    miniksa committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    54ce99e View commit details
    Browse the repository at this point in the history
  2. Format pass.

    miniksa committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    8647ae0 View commit details
    Browse the repository at this point in the history
  3. PR feedback. Restoring non-optional dirty. Removing some leftover com…

    …ments. Taking out the MUL for scaling since it's unused and confusing.
    miniksa committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0fc48b9 View commit details
    Browse the repository at this point in the history
  4. tabs to spaces

    miniksa committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    7a5a3d3 View commit details
    Browse the repository at this point in the history
  5. fix the til bitmap and tests for removing the optional... I swear I c…

    …ompiled this before the last push and it didn't fail.
    miniksa committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    91c11d9 View commit details
    Browse the repository at this point in the history