Gracefully handle json data with the wrong value types #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-Settings
…rong-settings-types # Conflicts: # src/cascadia/TerminalApp/Profile.cpp
ghost
requested review from
DHowett-MSFT
approved these changes
Mar 20, 2020
DHowett-MSFT
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Currently, if the Terminal attempts to parse a setting that should be a
booland the user provided a string, then we'll throw an exception while parsing the
settings, and display an error message that's pretty unrelated to the actual
problem.
The same goes for
bools asints,floats asints, etc.This PR instead updates our settings parsing to ensure that we check the type of
a json value before actually trying to get its parsed value.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I made a bunch of
JsonUtilshelpers for this in the same vein as theGetOptionalValueones.Notably, any other value type can safely be treated as a string value.
Validation Steps Performed