Make ctrl+shift+scroll toggle acrylic on/off at extrema #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Mar 10, 2020
zadjii-msft
added
Area-TerminalControl
ghost
requested review from
carlos-zamora
approved these changes
Mar 10, 2020
Yeah, that makes sense. I did try it initially, but I was seeing that it goes back to acrylic mode if mouse scrolls one more step after hitting 100% mark. Let me see if I can figure something to work around it. |
|
@DHowett-MSFT, added change to turn off acrylic if opacity hits 100%. |
zadjii-msft
approved these changes
Mar 10, 2020
|
Just needs invoke-codeformat run on it now! 😄 |
abhijeetviswam
force-pushed
the
feature-AcrylicAutoEnable
branch
from
90e0336
to
a7a6554
Compare
DHowett-MSFT
approved these changes
Mar 11, 2020
DHowett-MSFT
changed the title
abhijeetviswam
added a commit
to abhijeetviswam/terminal
that referenced
this pull request
Mar 12, 2020
If UseAcrylic is disabled, CTRL+SHIFT+SCROLL would enable it, without having to change the setting in profile.json manually. 1. Set "useAcrylic" to false for the any profile in profile.json 2. Open terminal window for that profile. 3. CTRL+SHIFT+MouseScroll Acrylic background opacity should change according to mouse scroll ## PR Checklist * [x] CLA signed. * [x] Tested manually * [x] Updated documentation Closes microsoft#661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
If UseAcrylic is disabled, CTRL+SHIFT+SCROLL would enable it, without having to change the setting in profile.json manually.
References
#661
PR Checklist
Detailed Description of the Pull Request / Additional comments
If UseAcrylic is disabled, CTRL+SHIFT+Scroll would enable it and acrylic background brush is initialized.
Validation Steps Performed
Acrylic background opacity should change according to mouse scroll