-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fire UIA Events for Output and Cursor Movement #4826
Conversation
I meant to publish this PR as a draft but I guess there's no undo button... |
This PR allows NVDA to fully support Terminal. Corresponding NVDA-side changes are in nvaccess/nvda#10784. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I'm holding my check to see what else narrator needs, but so far looks good
729de14
to
56bfc6b
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Given the latest commit, looks like NVDA 2020.1 works fine. EDIT: this also crashes accevent. So this leads me to believe that something bad is going on with dispatching our CursorChanged event. |
This is me noting that I saw this PR and am not reviewing at this time because @carlos-zamora says there's still some nasty crash. |
Any chance this PR could be merged without 522b99a and the rest of the event support (for Narrator) Could be added in subsequent PRs? This would allow NVDA to support Terminal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really love a comment where Leon called out, but sure
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
## Summary of the Pull Request This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen. ## References Close #2447 - Signaling for new output and cursor Close #3791 - fixed by signaling cursor changes ## Detailed Description of the Pull Request / Additional comments - Added tracing for UiaRenderer. This makes it easier to debug issues with notifying an automation client. - Fire TextChanged automation events when new content is output to the screen. ## Validation Steps Performed Verified with NVDA [1] ## Narrator Narrator works _better_, but is unable to detect new output consistently. There is no harm for narrator when this change goes in. [1] #2447 (comment)
Any idea when this PR will make it to Windows Store users? |
Aiming for tomorrow. |
Wow, that was good timing! |
🎉 Handy links: |
Summary of the Pull Request
This notifies automation clients (i.e.: NVDA, narrator, etc...) of new output being rendered to the screen.
References
Close #2447 - Signaling for new output and cursor
Close #3791 - fixed by signaling cursor changes
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Verified with NVDA [1]
Narrator
Narrator works better, but is unable to detect new output consistently. There is no harm for narrator when this change goes in.
[1] #2447 (comment)