Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shift+ins to defaults.json #4467

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Conversation

cinnamon-msft
Copy link
Contributor

Summary of the Pull Request

Added shift+insert as a keybinding for paste in defaults.json

References

PR Checklist

  • Closes somebody needs to add ctrl&shift+ins to the default settings #3162
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

I tried it in Ubuntu and it works.

@cinnamon-msft cinnamon-msft changed the title Added shift-ins to defaults.json Added shift+ins to defaults.json Feb 5, 2020
@cinnamon-msft cinnamon-msft requested a review from a team February 5, 2020 00:21
@DHowett-MSFT
Copy link
Contributor

DHowett-MSFT commented Feb 5, 2020

Should we also add ctrl+ins for copy? Should we also put this in defaults-universal.json?

@zadjii-msft
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cinnamon-msft cinnamon-msft added the Needs-Second It's a PR that needs another sign-off label Feb 5, 2020
@DHowett-MSFT
Copy link
Contributor

re-running just x86.

@cinnamon-msft cinnamon-msft merged commit 4a3ed3e into master Feb 5, 2020
@cinnamon-msft cinnamon-msft deleted the cinnamon/default-shift-ins branch February 5, 2020 18:01
@ghost
Copy link

ghost commented Feb 13, 2020

🎉Windows Terminal Preview v0.9.433.0 has been released which incorporates this pull request.:tada:

Handy links:

@jelez
Copy link

jelez commented Mar 1, 2020

what is the default for Microsoft Surface Laptop users (there is no Ins key there)

@zadjii-msft
Copy link
Member

@jelez the you can also use ctrl+shift+c for copy:

{ "command": "copy", "keys": "ctrl+shift+c" },
{ "command": "copy", "keys": "ctrl+insert" },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Second It's a PR that needs another sign-off
Projects
None yet
Development

Successfully merging this pull request may close these issues.

somebody needs to add ctrl&shift+ins to the default settings
4 participants