Introduce UiaTextRangeBase::FindText() for Accessibility #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove _degenerate - _start and _end are now COORDs - _end is always exclusive - de-static-fy functions - all COORDs are in the text buffer coordinate system
Get some tests running again
…ange Missing tests for... - GetText - Move - MoveEndpointByUnit Still need to think of how to approach Move and MoveEndpointByUnit since these should be very similar and should reuse a lot of code.
…llptr when attribute not found. Don't know why this is an issue _now_
- disable debug log
Narrator's word navigation has regressed. This PR will not be ready until that is fixed.
|
I messed up and #4373 got closed on me because the base branch (UTR Refactor) got merged/deleted. Not sure what to do so I created a new PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Moved
FindTexttoUiaTextRangeBase. Now that Search is a shared component (thanks #3279), I can just reuse it basically as-is.References
#3279 - Make Search a shared component
#4018 - UiaTextRange Refactor
PR Checklist
Detailed Description of the Pull Request / Additional comments
I removed it from the two different kinds of UiaTextRange and put it in the base class.
I needed a very minor change to ensure we convert from an inclusive end (from Search) to an exclusive end (in UTR).
Worked with
FindTextwas globally messed with in windows.h. So we had to do a few weird things there (thanks Michael).No need for additional tests because it literally just sets up a Searcher and calls it.
Validation Steps Performed
I didn't even test this