No more are you sure boxes

[rstat1]

Summary of the Pull Request

So this PR adds a profile setting called "confirmCloseAllTabs", that allows one to enable or disable the "Do you want close all tabs?" dialog that appears when you close a window with multiple open tabs. It current defaults to "true". Also adds a checkbox to that dialog that also sets "confirmCloseAllTabs"

References

PR Checklist

• Closes Feature request: Close on multiple tabs confirmation dialog being optional. #3883
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I added a checkbox to the close dialog to set this setting, but I'm not sure how to best go about actually changing the setting from code; am open to suggestions, as to how it should be done, or if I should also just remove it and stick with the profile setting.

Validation Steps Performed

1. Set "confirmCloseAllTabs" to false in my profile.json file.
2. Opened a 2nd tab.
3. Closed the window
4. Observed that there was no confirmation before the window closed.
5. Set "confirmCloseAllTabs" to true
6. Repeat steps 2 and 3
7. Observe that there was a confirmation before the window closed.

[zadjii-msft]

Okay I really like this so far, but I think it'll be easiest to just add the setting in profiles.json right now, and not add the checkbox in this PR.

Right now, we're only really writing out the profiles.json file when dynamic profiles are added, and when that happens, we're surgically modifying the profiles.json file to insert the new profiles - we're not re-serializing the settings. Unfortunately, I'm not sure that surgical insertion code could be easily re-used for this scenario. It might be tricky to add similar code to enable writing out an update of a single setting like this. If you're really interested, you could look at CascadiaSettings::_AppendDynamicProfilesToUserSettings and CascadiaSettings::_PrependSchemaDirective for samples, but HERE BE DRAGONS.

I'd rather just get the setting added now, and figure out the tricky part later IMO.

[rstat1]

Ok, so I also removed the checkbox (and related event handlers) as well. Though I would like to revisit doing that later.

[carlos-zamora]

Also make sure you update the following files with the new setting:

• SettingsSchema.md
• profiles.schema.json

I think the setting key is ok too, but I wanna quickly poll @cinnamon-msft for her thoughts just to keep her in the loop 😊

[zadjii-msft]

I like it. Thanks!

[cinnamon-msft]

I dig this :)

[ghost]

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[miniksa]

Thanks!

stale

[ghost]

🎉Windows Terminal Preview v0.9.433.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download